8386698: PlatformUtil has unused fields and methods

[Maran23]

When I did #2146, I touched PlatformUtil and saw that some methods and fields are unused and will probably never be used.

Example:

• isWinVistaOrLater()
• useGLES2()

So I removed them. Also checked that they are not called by native code.
I kept isHeadless(), as it was used in a test at one point and might be needed again at some point.
Moved isAndroid right below the other isXXX methods.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8386698: PlatformUtil has unused fields and methods (Enhancement - P4)

Reviewers

• Lukasz Kostyra (@lukostyra - Reviewer)
• Andy Goryachev (@andy-goryachev-oracle - Reviewer)
• Johan Vos (@johanvos - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/2190/head:pull/2190
$ git checkout pull/2190

Update a local copy of the PR:
$ git checkout pull/2190
$ git pull https://git.openjdk.org/jfx.git pull/2190/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2190

View PR using the GUI difftool:
$ git pr show -t 2190

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/2190.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mhanl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Maran23 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8386698: PlatformUtil has unused fields and methods

Reviewed-by: lkostyra, angorya, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 6e2f869: 8382256: Unused method in TreeUtil can be cleaned up

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

The total number of required reviews for this PR has been set to 2 based on the presence of this label: rfr. This can be overridden with the /reviewers command.

[mlbridge]

Webrevs

• 00: Full (c1803523)

[lukostyra]

Looks good. Tests run as per usual and these don't seem to be used anywhere.

[andy-goryachev-oracle]

isHeadless() is still being used by MacPasteboardTest.

[andy-goryachev-oracle]

Looks good. I wonder if @johanvos should also take a look at this change, just in case.

[Maran23]

isHeadless() is still being used by MacPasteboardTest.

You are right! My IDE was not listing this class for whatever reason - IntelliJ seems to have problems with detecting systemTests sometimes for me. Even better that it is used!

Looks good. I wonder if @johanvos should also take a look at this change, just in case.

+1. Even though this is an internal class, I was wondering the same thing (maybe there's some custom code at Gluon or similar). Will wait until we get a response, since it's not urgent.

[johanvos]

The removed fields do not affect the mobile ports.

[johanvos]

thanks for pinging me. No harm done by removing those fields.

[Maran23]

/integrate

[openjdk]

Going to push as commit b932758.
Since your change was applied there has been 1 commit pushed to the master branch:

• 6e2f869: 8382256: Unused method in TreeUtil can be cleaned up

Your commit was automatically rebased without conflicts.

[openjdk]

@Maran23 Pushed as commit b932758.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.