fix examples for ref and autoref#1341
Open
sneakers-the-rat wants to merge 1 commit into
Open
Conversation
xuanxu
approved these changes
May 22, 2024
Member
There was a problem hiding this comment.
LGTM
Consulted with @tarleb; the problem is that the labels mentioned in the docs do work, but only when going via ConTeXt instead of LaTeX. We expected a switch to ConTeXt soon, so this wasn't implemented for LaTeX. Maybe is better to fix the LaTeX output rather than changing the docs.
Member
|
@arfon about ConTeXt vs LaTeX: any word on what you think we'll use in the future? |
Contributor
Author
|
Gotcha! Didnt know that. Feel free to close this if other plans |
Contributor
Author
|
ping on this, still broken |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #1340
looks like this wasn't working even before the transition to myst: https://web.archive.org/web/20230925202053/https://joss.readthedocs.io/en/latest/submitting.html#internal-references
left in the mention of the markdown-style labels even if they aren't working for now bc i assume that will be fixed.
Before:
After:
