fix(bedrock): accept size positional argument#488
Merged
whoseoyster merged 1 commit intonextfrom Jul 17, 2025
Merged
Conversation
whoseoyster
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
The Bedrock tracer was causing a runtime error when customers tried to read the response body after a model invocation.
Updated the
mock read()method to accept the optional size parameter:lambda size=-1: response_bytes[:size] if size > 0 else response_bytes, making it compatible with boto3'sStreamingBody.read()signature.This ensures the traced response behaves identically to the original boto3 response for downstream code.