Skip to content

fix(tracing): improve error handling in sync generator finalization #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gustavocidornelas merged 1 commit into from
Aug 20, 2025
Merged

fix(tracing): improve error handling in sync generator finalization #506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/openlayer/lib/tracing/tracer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,7 +729,14 @@ def _finalize_sync_generator_step(
inference_pipeline_id: Optional[str] = None,
) -> None:
"""Finalize sync generator step - called when generator is consumed."""
_current_step.reset(token)
try:
_current_step.reset(token)
except ValueError:
# Context variable was created in a different context (e.g., different thread)
# This can happen in async/multi-threaded environments like FastAPI/OpenWebUI
# We can safely ignore this as the step finalization will still complete
logger.debug("Context variable reset failed - generator consumed in different context")

_finalize_step_logging(step=step, inputs=inputs, output=output, start_time=step.start_time)
_handle_trace_completion(
is_root_step=is_root_step,
Expand Down