Merge pull request #162 from gberaudo/handle_features_without_geometry

Handle features without geometry

Author: gberaudo

examples/vectors.js

@@ -106,7 +106,9 @@ var styles = {
 };
 
 var styleFunction = function(feature, resolution) {
-  return styles[feature.getGeometry().getType()];
+  var geo = feature.getGeometry();
+  // always assign a style to prevent feature skipping
+  return geo ? styles[geo.getType()] : styles['Point'];
 };
 
 var vectorSource = new ol.source.GeoJSON(
@@ -120,6 +122,13 @@ var vectorSource = new ol.source.GeoJSON(
           }
         },
         'features': [
+          {
+            'type': 'Feature',
+            'geometry': null,
+            'properties': {
+              'type': 'without geometry as allowed in spec',
+            }
+          },
           {
             'type': 'Feature',
             'geometry': {

src/core.js

@@ -1089,6 +1089,11 @@ goog.require('olcs.core.OlLayerPrimitive');
   olcs.core.olFeatureToCesium = function(feature, style, context, opt_geom) {
     var geom = opt_geom || feature.getGeometry();
     var proj = context.projection;
+    if (!geom) {
+      // Ol3 features may not have a geometry
+      // See http://geojson.org/geojson-spec.html#feature-objects
+      return null;
+    }
 
     var id = function(object) {
       object.olFeature = feature;