Fix #998 - ol layer vectorImage is not rendered#1005
Open
or4inveni wants to merge 2 commits into
Open
Conversation
gberaudo
requested changes
Nov 23, 2022
Member
gberaudo
left a comment
gberaudo
left a comment
There was a problem hiding this comment.
Thanks for your PR. Could you please address my comments?
Comment on lines
+106
to
+109
| let convertedVectorLayer = new olLayerVector({source: null}); | ||
| convertedVectorLayer.setStyle(olLayerWithParents.layer.getStyle()) | ||
| convertedVectorLayer.setSource(olLayerWithParents.layer.getSource()) | ||
| olLayer = convertedVectorLayer; |
Member
There was a problem hiding this comment.
Please directly pass source and style as constructor parameter.
Notably, see https://openlayers.org/en/latest/apidoc/module-ol_layer_Vector-VectorLayer.html
| "@types/webpack": "^5.28.0", | ||
| "babel-loader": "8.2.2", | ||
| "cesium": "^1.81.0", | ||
| "cesium": ">=1.81.0 <=1.97.0", |
Comment on lines
+2
to
+3
| "name": "@inveni/ol-cesium", | ||
| "version": "0.00.1", |
|
Hi is this fixed? Cause i still have problems showing image vector layers in 3d? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#998 simple fix for the issue 998 like discussed with @gberaudo
Warning: as the current latest cesium version 1.98.0 is breaking the whole ol-cesium library this commit limits the cesium version to 1.97.0