Skip to content

Commit 29e3f00

Browse files
author
Open Lowcode SAS
committed
Merge remote-tracking branch 'origin/master'
Conflicts: src/org/openlowcode/tools/pdf/PDFMultiPageTable.java
2 parents 137ef43 + 4eba8e3 commit 29e3f00

File tree

6 files changed

+167
-14
lines changed

6 files changed

+167
-14
lines changed
Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
---
2+
name: Bug report
3+
about: Create a report to help us improve
4+
title: ''
5+
labels: ''
6+
assignees: ''
7+
8+
---
9+
10+
**Describe the bug**
11+
A clear and concise description of what the bug is.
12+
13+
**To Reproduce**
14+
Steps to reproduce the behavior:
15+
1. Go to '...'
16+
2. Click on '....'
17+
3. Scroll down to '....'
18+
4. See error
19+
20+
**Expected behavior**
21+
A clear and concise description of what you expected to happen.
22+
23+
**Screenshots**
24+
If applicable, add screenshots to help explain your problem.
25+
26+
**Desktop (please complete the following information):**
27+
- OS: [e.g. iOS]
28+
- Browser [e.g. chrome, safari]
29+
- Version [e.g. 22]
30+
31+
**Smartphone (please complete the following information):**
32+
- Device: [e.g. iPhone6]
33+
- OS: [e.g. iOS8.1]
34+
- Browser [e.g. stock browser, safari]
35+
- Version [e.g. 22]
36+
37+
**Additional context**
38+
Add any other context about the problem here.
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
---
2+
name: Feature request
3+
about: Suggest an idea for this project
4+
title: ''
5+
labels: ''
6+
assignees: ''
7+
8+
---
9+
10+
**Is your feature request related to a problem? Please describe.**
11+
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
12+
13+
**Describe the solution you'd like**
14+
A clear and concise description of what you want to happen.
15+
16+
**Describe alternatives you've considered**
17+
A clear and concise description of any alternative solutions or features you've considered.
18+
19+
**Additional context**
20+
Add any other context or screenshots about the feature request here.
21+
22+
**Timeframe and Conditions**
23+
Precise here if you have a specific timeframe in mind, and may consider having the feature developed for a fee

CODE_OF_CONDUCT.md

Lines changed: 76 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
1+
# Contributor Covenant Code of Conduct
2+
3+
## Our Pledge
4+
5+
In the interest of fostering an open and welcoming environment, we as
6+
contributors and maintainers pledge to making participation in our project and
7+
our community a harassment-free experience for everyone, regardless of age, body
8+
size, disability, ethnicity, sex characteristics, gender identity and expression,
9+
level of experience, education, socio-economic status, nationality, personal
10+
appearance, race, religion, or sexual identity and orientation.
11+
12+
## Our Standards
13+
14+
Examples of behavior that contributes to creating a positive environment
15+
include:
16+
17+
* Using welcoming and inclusive language
18+
* Being respectful of differing viewpoints and experiences
19+
* Gracefully accepting constructive criticism
20+
* Focusing on what is best for the community
21+
* Showing empathy towards other community members
22+
23+
Examples of unacceptable behavior by participants include:
24+
25+
* The use of sexualized language or imagery and unwelcome sexual attention or
26+
advances
27+
* Trolling, insulting/derogatory comments, and personal or political attacks
28+
* Public or private harassment
29+
* Publishing others' private information, such as a physical or electronic
30+
address, without explicit permission
31+
* Other conduct which could reasonably be considered inappropriate in a
32+
professional setting
33+
34+
## Our Responsibilities
35+
36+
Project maintainers are responsible for clarifying the standards of acceptable
37+
behavior and are expected to take appropriate and fair corrective action in
38+
response to any instances of unacceptable behavior.
39+
40+
Project maintainers have the right and responsibility to remove, edit, or
41+
reject comments, commits, code, wiki edits, issues, and other contributions
42+
that are not aligned to this Code of Conduct, or to ban temporarily or
43+
permanently any contributor for other behaviors that they deem inappropriate,
44+
threatening, offensive, or harmful.
45+
46+
## Scope
47+
48+
This Code of Conduct applies both within project spaces and in public spaces
49+
when an individual is representing the project or its community. Examples of
50+
representing a project or community include using an official project e-mail
51+
address, posting via an official social media account, or acting as an appointed
52+
representative at an online or offline event. Representation of a project may be
53+
further defined and clarified by project maintainers.
54+
55+
## Enforcement
56+
57+
Instances of abusive, harassing, or otherwise unacceptable behavior may be
58+
reported by contacting the project team at welcome@openlowcode.com. All
59+
complaints will be reviewed and investigated and will result in a response that
60+
is deemed necessary and appropriate to the circumstances. The project team is
61+
obligated to maintain confidentiality with regard to the reporter of an incident.
62+
Further details of specific enforcement policies may be posted separately.
63+
64+
Project maintainers who do not follow or enforce the Code of Conduct in good
65+
faith may face temporary or permanent repercussions as determined by other
66+
members of the project's leadership.
67+
68+
## Attribution
69+
70+
This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
71+
available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html
72+
73+
[homepage]: https://www.contributor-covenant.org
74+
75+
For answers to common questions about this code of conduct, see
76+
https://www.contributor-covenant.org/faq

CONTRIBUTING.md

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
# How to contribute
2+
3+
You are welcome to contribute to the Open-Lowcode framework. Guidelines will be setup more precisely with time, feel free to:
4+
* raise bugs and issues on Github
5+
* propose simple improvements on Github. Of course, proposing a solution (pull request) is really appreciated.
6+
* discuss architecture questions and major priorities on the [forum](https://openlowcode.org/open-lowcode-forum/)
7+
8+
As a company using the Open-Lowcode framework, you can support the initiative by:
9+
* asking for extensions of the framework for a fee (available, just precise it when writing a feature request)
10+
* purchasing support to the product (not yet available)
11+
12+
# Courtesy & Manners
13+
14+
Some of the greatest mind in many areas practice perfect courtesy, there is no reason we do not do the same. Exchanging in a courteous and considerate manner is really appreciated.
15+
16+
# Core Values
17+
18+
Debate on the framework is highly welcome. The author of the framework fully acknowledges you may have stronger skills in a number of areas, and bring a lot of value and insights.
19+
20+
Nonetheless, the framework is built on a number of strong hypothesis and choices, contributors are expected to accept, or, at least, tolerate them. Values are discussed in greater length in the [Open Lowcode blog](https://openlowcode.com/blog/). Please take this as a warning that this is, say, a bossa-nova concert, and if you are expecting heavy-metal (or the other way round), you will likely be disappointed.
21+
22+
Some core values include:
23+
* keep complexity reasonnable. To make a parallel, if the tool was a rich-text format, the objective would be something like markdown (easy and good enough), not something like html (powerful but verbose). This is driven by the need to be usable in enterprise context with varying development skill levels.
24+
* prioritize performance and ease of debugging. This is one of the main drivers behind automatically generated code, compared to alternative approaches such as complex frameworks using reflection.
25+
* limit the number of dependencies, within reasons. Open Lowcode relies on major technological frameworks and standards such as SQL, Java SDK (not Enterprise), JavaFX, and some outstanding Apache libraries around PDF and reading office documents. However, the core of the framework is all home-made. This allows end-to-end optimization, and better control of obsolescence. There may be discussions on this point though on the margin, as probably, the current version takes things slightly to the extreme.
26+
* have reasonnable formal quality of code (but not more). The framework was developped under time constraints, and is likely to remain so for the foreseable future. It is fully acknowledge the code produced may not be used as example of good coding practices.

README.md

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
# Open-Lowcode
22
### Open-source Low-code platform to build applications quick and fast.
33

4-
published by [Open Lowcode SAS](https://openlowcode.com). You may also want to look at the [Community Page](https://openlowcode.org).
4+
published by [Open Lowcode SAS](https://openlowcode.com). You may also want to look at the [Community Page](https://openlowcode.org) and the [javadoc](https://openlowcode.org/javadoc/).
55

6-
The project includes the main low-code platform (a full application server), and also some java tools you may find useful in other contexts. You are of course very welcome to use just the java tools if it makes sense for you.
6+
The project includes the main low-code platform (a full application server), and also some java tools you may find useful in other contexts. You are of course very welcome to use just the java tools if it makes sense for you. As of today, the Open Lowcode PDF framework is released.
77

88
You are welcome to get involved and contribute to the project by:
99
* suggesting new features or bug corrections. right here on github or on the [community forum](https://openlowcode.org/open-lowcode-forum/). Of course, the fixes will be best effort
@@ -12,14 +12,4 @@ You are welcome to get involved and contribute to the project by:
1212

1313
This is the first open-source project of the author, so there may be technical mistakes done, do not hesitate to suggest improvements on the way the project is organized too.
1414

15-
# Core Values
16-
17-
Debate on the framework is highly welcome. The author of the framework fully acknowledges you may have stronger skills in a number of areas, and bring a lot of value and insights.
18-
19-
Nonetheless, the framework is built on a number of strong hypothesis and choices, contributors are expected to accept, or, at least, tolerate them. Values are discussed in greater length in the [Open Lowcode blog](https://openlowcode.com/blog/). Please take this as a warning that this is, say, a bossa-nova concert, and if you are expecting heavy-metal (or the other way round), you will likely be disappointed.
20-
21-
Some core values include:
22-
* keep complexity reasonnable. To make a parallel, if the tool was a rich-text format, the objective would be something like markdown (easy and good enough), not something like html (powerful but verbose). This is driven by the need to be usable in enterprise context with varying development skill levels.
23-
* prioritize performance and ease of debugging. This is one of the main drivers behind automatically generated code, compared to alternative approaches such as complex frameworks using reflection.
24-
* limit the number of dependencies, within reasons. Open Lowcode relies on major technological frameworks and standards such as SQL, Java SDK (not Enterprise), JavaFX, and some outstanding Apache libraries around PDF and reading office documents. However, the core of the framework is all home-made. This allows end-to-end optimization, and better control of obsolescence. There may be discussions on this point though on the margin, as probably, the current version takes things slightly to the extreme.
25-
* have reasonnable formal quality of code (but not more). The framework was developped under time constraints, and is likely to remain so for the foreseable future. It is fully acknowledge the code produced may not be used as example of good coding practices.
15+
You may also want to consult the [contributor guidelines](https://github.com/openlowcode/Open-Lowcode/blob/master/CONTRIBUTING.md) and [code of conduct](https://github.com/openlowcode/Open-Lowcode/blob/master/CODE_OF_CONDUCT.md).

src/org/openlowcode/tools/pdf/PDFMultiPageTable.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ private float getLineHeight(float leftinmm, float rightinmm, int lineindex) thro
276276
float maxheight = 0;
277277

278278
for (int i = 0; i < this.columnnumber; i++) {
279-
float columnwidth = this.columnwidthinmm[i];
279+
float columnwidth = this.columnwidthinmm[i];
280280
float cellheight = getCellHeight(columnwidth, lineindex, i);
281281
if (cellheight > maxheight)
282282
maxheight = cellheight;

0 commit comments

Comments
 (0)