Close #115

Author: Open Lowcode SAS

src/org/openlowcode/design/advanced/ChoiceFilterElement.java

@@ -212,4 +212,9 @@ public boolean hasSuggestionValues() {
 	public ArgumentContent getSuggestionArgumentContent(String suffix) {
 		return null;
 	}
+
+	@Override
+	public boolean needArrayOfObjectId() {
+		return false;
+	}
 }

src/org/openlowcode/design/advanced/FilterElement.java

@@ -84,6 +84,14 @@ public boolean isHardCoded() {
 	 */
 	public abstract boolean hasSuggestionValues();
 
+	/**
+	 * tells if the filter data gathering need an array of object ids
+	 * 
+	 * @return true if the filter needs an array of object ids
+	 * @since 1.7
+	 */
+	public abstract boolean needArrayOfObjectId();
+	
 	/**
 	 * provides the argument for the suggestion, typically a list of strings for a
 	 * string field

src/org/openlowcode/design/advanced/FilterElementLink.java

@@ -205,12 +205,7 @@ public void writeFilterInDataGathering(
 		String rightobjectattribute = StringFormatter.formatForAttribute(linkobject.getRightobjectforlink().getName());
 		String leftobjectclass = StringFormatter.formatForJavaClass(linkobject.getLeftobjectforlink().getName());
 		String leftobjectattribute = StringFormatter.formatForAttribute(linkobject.getLeftobjectforlink().getName());
-		logger.severe("Writing filter in data gathering for node " + prefixforobject + " for FilterElementLink");
-		sg.wl("		DataObjectId<" + leftobjectclass + ">[] " + leftobjectattribute + "_step" + prefixforobject
-				+ "_id = new DataObjectId[" + leftobjectattribute + "_step" + prefixforobject + ".length];");
-		sg.wl("		for (int i=0;i<" + leftobjectattribute + "_step" + prefixforobject + ".length;i++) "
-				+ leftobjectattribute + "_step" + prefixforobject + "_id[i] = " + leftobjectattribute + "_step"
-				+ prefixforobject + "[i].getId();");
+
 		sg.wl("		TwoDataObjects<" + linkobjectclass + "," + rightobjectclass + ">[] " + leftobjectattribute + "_step"
 				+ prefixforobject + "_filteron" + rightobjectattribute + " = " + linkobjectclass
 				+ ".getlinksandrightobject(" + leftobjectattribute + "_step" + prefixforobject + "_id, null);");
@@ -246,4 +241,9 @@ public ArgumentContent getSuggestionArgumentContent(String suffix) {
 		return null;
 	}
 
+	@Override
+	public boolean needArrayOfObjectId() {
+		return true;
+	}
+
 }

src/org/openlowcode/design/advanced/LineGroupingCriteria.java

@@ -101,4 +101,10 @@ protected abstract void writeClassification(
 	 * @throws IOException if anything bad
 	 */
 	protected abstract void writeFields(SourceGenerator sg, String prefix) throws IOException;
+
+	/**
+	 * @return true if the grouping element needs to have an array of object ids
+	 *         queried before
+	 */
+	public abstract boolean needArrayOfObjectId();
 }

src/org/openlowcode/design/advanced/LineGroupingCriteriaChoice.java

@@ -106,4 +106,9 @@ protected void feedfields(ArrayList<Field> fieldlist, boolean before) {
 	protected void writeFields(SourceGenerator sg, String prefix) {
 
 	}
+
+	@Override
+	public boolean needArrayOfObjectId() {
+		return false;
+	}
 }

src/org/openlowcode/design/advanced/LineGroupingCriteriaObject.java

@@ -239,4 +239,9 @@ protected void writeFields(SourceGenerator sg, String prefix) throws IOException
 		}
 
 	}
+
+	@Override
+	public boolean needArrayOfObjectId() {
+		return false;
+	}
 }

src/org/openlowcode/design/advanced/LineGroupingCriteriaText.java

@@ -105,4 +105,9 @@ protected void feedfields(ArrayList<Field> fieldlist, boolean before) {
 	protected void writeFields(SourceGenerator sg, String prefix) {
 		// donothing
 	}
+
+	@Override
+	public boolean needArrayOfObjectId() {
+		return false;
+	}
 }

src/org/openlowcode/design/advanced/LineGroupingCriteriaUniqueLink.java

@@ -95,6 +95,7 @@ public String[] getImportStatements() {
 				+ StringFormatter.formatForJavaClass(linkobject.getParent().getName()) + ";");
 		importstatements.add("import " + linkobject.getRightobjectforlink().getOwnermodule().getPath() + ".data."
 				+ StringFormatter.formatForJavaClass(linkobject.getRightobjectforlink().getName()) + ";");
+		importstatements.add("import org.openlowcode.server.data.TwoDataObjects;");
 		return importstatements.toArray(new String[0]);
 	}
 
@@ -128,4 +129,9 @@ protected void feedfields(ArrayList<Field> fieldlist, boolean before) {
 	protected void writeFields(SourceGenerator sg, String prefix) {
 		// donothing
 	}
+
+	@Override
+	public boolean needArrayOfObjectId() {
+		return true;
+	}
 }

src/org/openlowcode/design/advanced/LinkedToChildrenNodeLink.java

@@ -133,6 +133,18 @@ protected void gatherData(
 					+ "_step" + prefixparent + ",QueryFilter.get(" + queryattribute + "));");
 
 		}
+		boolean hasidtable = false;
+		if (filterelements!=null) for (int i=0;i<filterelements.size();i++) if (filterelements.get(i).needArrayOfObjectId()) hasidtable=true;
+		if (groupingelements!=null) for (int i=0;i<groupingelements.size();i++) if (groupingelements.get(i).needArrayOfObjectId()) hasidtable=true;
+		
+		if (hasidtable) {
+			sg.wl("		DataObjectId<" + childclass + ">[] " + childattribute + "_step" + prefixforlinkandchild
+					+ "_id = new DataObjectId[" + childattribute + "_step" + prefixforlinkandchild + ".length];");
+			sg.wl("		for (int i=0;i<" + childattribute + "_step" + prefixforlinkandchild + ".length;i++) "
+					+ childattribute + "_step" + prefixforlinkandchild + "_id[i] = " + childattribute + "_step"
+					+ prefixforlinkandchild + "[i].getId();");
+		}
+		
 		if (filterelements != null)
 			for (int i = 0; i < filterelements.size(); i++) {
 				FilterElement<?> thiselement = filterelements.get(i);

src/org/openlowcode/design/advanced/TextFilterElement.java

@@ -217,4 +217,9 @@ public Field getFieldForSuggestion() {
 		return this.stringfield;
 	}
 
+	@Override
+	public boolean needArrayOfObjectId() {
+		return false;
+	}
+
 }