Close #105

Author: Open Lowcode SAS

src/org/openlowcode/client/graphic/widget/CBusinessField.java

@@ -163,7 +163,9 @@ public void setActive(boolean active) {
 			int preferedrowheight,
 			String actionkeyforupdate);
 
+
 	/**
+	 * @param pageactionmanager    action manager
 	 * @param preferedrowheight    prefered height for row (note: not used for big
 	 *                             decimal, not implemented for other fields
 	 * @param actionkeyforupdate   update action key
@@ -177,7 +179,7 @@ public void setActive(boolean active) {
 	 *                             only one field display). if wrong, title is the
 	 *                             current column title (good for several fields
 	 *                             displays
-	 * @return
+	 * @return a table column to be used in grid classical layout
 	 */
 	public abstract TableColumn<CObjectGridLine<String>, ?> getTableColumnForGrid(
 			PageActionManager pageactionmanager,

src/org/openlowcode/client/graphic/widget/CTextField.java

@@ -1057,6 +1057,7 @@ public void pingValue() {
 
 	}
 
+	
 	@Override
 	public TableColumn<CObjectGridLine<String>, ?> getTableColumnForGrid(
 			PageActionManager pageactionmanager,

src/org/openlowcode/design/data/properties/basic/LinkObject.java

@@ -60,6 +60,7 @@ public class LinkObject<E extends DataObjectDefinition, F extends DataObjectDefi
 	private boolean hasfieldshown = false;
 	private int priorityforleft;
 	private int priorityforright;
+	private boolean setidsmodifiable = false;
 
 	/**
 	 * @param priorityforleft
@@ -83,6 +84,15 @@ public UniqueIdentified getUniqueIdentified() {
 	private WidgetDisplayPriority displaypriorityfromleft;
 	private WidgetDisplayPriority displaypriorityfromright;
 
+	/**
+	 * makes the ids of left and right object modifiable from client client. This
+	 * can be a security risk, with the possibility for data to be tampered if
+	 * someone uses a non-standard client
+	 */
+	public void setIdsmodifiable() {
+		this.setidsmodifiable = true;
+	}
+
 	/**
 	 * @return
 	 */
@@ -152,7 +162,38 @@ public LinkObject(
 			String labelfromright,
 			WidgetDisplayPriority displaypriorityfromleft,
 			WidgetDisplayPriority displaypriorityfromright) {
+		this(leftobjectforlink, rightobjectforlink, labelfromleft, labelfromright, displaypriorityfromleft,
+				displaypriorityfromright, false);
+	}
+
+	/**
+	 * creates a link object with specified label from left object, and label from
+	 * right object for the link (e.g. for a wedding link between a man and a woman,
+	 * you could display 'husband' and 'wife' as specific label). Priority for the
+	 * widgets on left and right objects is also specified
+	 * 
+	 * @param leftobjectforlink        the left object of the link
+	 * @param rightobjectforlink       the right object of the link
+	 * @param labelfromleft            label of the link table seen from left object
+	 * @param labelfromright           label of the link table seen from right
+	 *                                 object
+	 * @param displaypriorityfromleft  priority display from the left object
+	 * @param displaypriorityfromright priority display from the right object
+	 * @param setidsmodifiable         put true if ids should be modifiable from
+	 *                                 client. This can be a security risk, with the
+	 *                                 possibility for data to be tampered if
+	 *                                 someone uses a non-standard client
+	 */
+	public LinkObject(
+			E leftobjectforlink,
+			F rightobjectforlink,
+			String labelfromleft,
+			String labelfromright,
+			WidgetDisplayPriority displaypriorityfromleft,
+			WidgetDisplayPriority displaypriorityfromright,
+			boolean setidsmodifiable) {
 		this(leftobjectforlink, rightobjectforlink, labelfromleft, labelfromright);
+		this.setidsmodifiable = setidsmodifiable;
 		this.displaypriorityfromleft = displaypriorityfromleft;
 		this.displaypriorityfromright = displaypriorityfromright;
 		if (this.displaypriorityfromleft != null)
@@ -333,8 +374,11 @@ public void controlAfterParentDefinition() {
 
 		// -- process arguments
 		if (this.hasfieldshown) {
-			this.setExtraAttributes("," + this.priorityforleft + "," + this.priorityforright);
+			this.setExtraAttributes("," + this.priorityforleft + "," + this.priorityforright+","+this.setidsmodifiable);
+		} else {
+			this.setExtraAttributes(","+this.setidsmodifiable);
 		}
+		
 
 	}
 

src/org/openlowcode/server/data/DataObjectPropertyDefinition.java

@@ -401,7 +401,9 @@ public static class FieldSchemaForDisplay<E extends DataObject<E>> {
 		private boolean richtext = false;
 		private FieldChoiceDefinition choiceforstring;
 		private DataObjectDefinition<E> objectdefinition;
-
+		
+		
+		
 		/**
 		 * defines this text as richtext
 		 */

src/org/openlowcode/server/data/properties/LinkobjectDefinition.java

@@ -43,8 +43,12 @@
  * @param <F> object at left of link
  * @param <G> object at right of link
  */
-public class LinkobjectDefinition<E extends DataObject<E> & LinkobjectInterface<E, F, G>, F extends DataObject<F> & UniqueidentifiedInterface<F>, G extends DataObject<G> & UniqueidentifiedInterface<G>>
-		extends DataObjectPropertyDefinition<E> {
+public class LinkobjectDefinition<
+		E extends DataObject<E> & LinkobjectInterface<E, F, G>,
+		F extends DataObject<F> & UniqueidentifiedInterface<F>,
+		G extends DataObject<G> & UniqueidentifiedInterface<G>>
+		extends
+		DataObjectPropertyDefinition<E> {
 	private DataObjectDefinition<F> leftobjectdefinition;
 	private DataObjectDefinition<G> rightobjectdefinition;
 	private StringStoredField leftid;
@@ -65,6 +69,7 @@ public class LinkobjectDefinition<E extends DataObject<E> & LinkobjectInterface<
 	private boolean showfieldsforrightobject;
 	private int minpriorityforleftobjectfields;
 	private int minpriorityforrightobjectfields;
+	private boolean makesidmodifiable = false;
 	private static Logger logger = Logger.getLogger(LinkobjectDefinition.class.getName());
 
 	/**
@@ -165,11 +170,18 @@ public boolean isReplaceifmorethanonefromleft() {
 	 *                                    shown on the link
 	 * @param showrightfieldswithpriority if set, right fields above the priority
 	 *                                    are shown on the link
+	 * @param makesidmodifiable     if true, the ids of links can be sent to a
+	 *                              client before having been persisted. This may be
+	 *                              a security risk that the data is tampered on the
+	 *                              client side
 	 */
-	public LinkobjectDefinition(DataObjectDefinition<E> parentobject, DataObjectDefinition<F> leftobjectdefinition,
-			DataObjectDefinition<G> rightobjectdefinition, int showleftfieldswithpriority,
-			int showrightfieldswithpriority) {
-		this(parentobject, leftobjectdefinition, rightobjectdefinition);
+	public LinkobjectDefinition(
+			DataObjectDefinition<E> parentobject,
+			DataObjectDefinition<F> leftobjectdefinition,
+			DataObjectDefinition<G> rightobjectdefinition,
+			int showleftfieldswithpriority,
+			int showrightfieldswithpriority,boolean makesidmodifiable) {
+		this(parentobject, leftobjectdefinition, rightobjectdefinition,makesidmodifiable);
 		if (showleftfieldswithpriority < 1000) {
 			this.showfieldsforleftobject = true;
 			this.minpriorityforleftobjectfields = showleftfieldswithpriority;
@@ -189,9 +201,16 @@ public LinkobjectDefinition(DataObjectDefinition<E> parentobject, DataObjectDefi
 	 * @param parentobject          parent object definition
 	 * @param leftobjectdefinition  definition of the left object for link
 	 * @param rightobjectdefinition definition of the right object for link
+	 * @param makesidmodifiable     if true, the ids of links can be sent to a
+	 *                              client before having been persisted. This may be
+	 *                              a security risk that the data is tampered on the
+	 *                              client side
 	 */
-	public LinkobjectDefinition(DataObjectDefinition<E> parentobject, DataObjectDefinition<F> leftobjectdefinition,
-			DataObjectDefinition<G> rightobjectdefinition) {
+	public LinkobjectDefinition(
+			DataObjectDefinition<E> parentobject,
+			DataObjectDefinition<F> leftobjectdefinition,
+			DataObjectDefinition<G> rightobjectdefinition,
+			boolean makesidmodifiable) {
 		super(parentobject, "LINKOBJECT");
 		this.leftobjectdefinition = leftobjectdefinition;
 		this.rightobjectdefinition = rightobjectdefinition;
@@ -217,6 +236,7 @@ public LinkobjectDefinition(DataObjectDefinition<E> parentobject, DataObjectDefi
 		this.replaceifmorethanonefromleft = false;
 		this.showfieldsforleftobject = false;
 		this.showfieldsforrightobject = false;
+		this.makesidmodifiable=makesidmodifiable;
 	}
 
 	/**
@@ -287,7 +307,9 @@ public UniqueidentifiedDefinition<G> getRightuniqueidentifieddefinition() {
 
 	/**
 	 * sets the dependent property unique identified for the link object
-	 * @param uniqueidentifieddefinition unique identified property for the left object
+	 * 
+	 * @param uniqueidentifieddefinition unique identified property for the left
+	 *                                   object
 	 */
 	public void setDependentDefinitionUniqueidentified(UniqueidentifiedDefinition<E> uniqueidentifieddefinition) {
 		this.uniqueidentifieddefinition = uniqueidentifieddefinition;
@@ -327,8 +349,8 @@ public ArrayList<ExternalFieldSchema<?>> generateExternalSchema() {
 		}
 		// get named property for left object
 		if (leftobjectdefinition.hasProperty("NUMBERED")) {
-			NumberedDefinition<F> numbereddefinition = (NumberedDefinition<F>) leftobjectdefinition
-					.getProperty("NUMBERED");
+			NumberedDefinition<
+					F> numbereddefinition = (NumberedDefinition<F>) leftobjectdefinition.getProperty("NUMBERED");
 			boolean orderedasnumber = false;
 			int numberoffset = 0;
 			if (numbereddefinition.getAutonumberingRule() != null)
@@ -355,8 +377,8 @@ public ArrayList<ExternalFieldSchema<?>> generateExternalSchema() {
 		// get state property for left object
 
 		if (leftobjectdefinition.hasProperty("LIFECYCLE")) {
-			LifecycleDefinition<?, ?> lifecycle = (LifecycleDefinition<?, ?>) (leftobjectdefinition
-					.getProperty("LIFECYCLE"));
+			LifecycleDefinition<
+					?, ?> lifecycle = (LifecycleDefinition<?, ?>) (leftobjectdefinition.getProperty("LIFECYCLE"));
 			ExternalFieldSchema<?> leftexternalfield = leftobjectdefinition.generateExternalField(
 					this.getName() + "LEFTSTATE", "Left state", "this is a stupid comment", "LIFECYCLE", "STATE",
 					lifecycle.getLifecycleHelper(), leftjoincondition, this.displayprofilehideleftobjectfields, 500,
@@ -408,8 +430,8 @@ public ArrayList<ExternalFieldSchema<?>> generateExternalSchema() {
 			// adds an external field is the target object is named -- currently, there is
 			// an error
 			@SuppressWarnings("unchecked")
-			NumberedDefinition<F> numbereddefinition = (NumberedDefinition<F>) rightobjectdefinition
-					.getProperty("NUMBERED");
+			NumberedDefinition<
+					F> numbereddefinition = (NumberedDefinition<F>) rightobjectdefinition.getProperty("NUMBERED");
 			boolean orderedasnumber = false;
 			int numberoffset = 0;
 			if (numbereddefinition.getAutonumberingRule() != null)
@@ -436,8 +458,8 @@ public ArrayList<ExternalFieldSchema<?>> generateExternalSchema() {
 			externalfieldlist.add(rightexternalfield);
 		}
 		if (rightobjectdefinition.hasProperty("LIFECYCLE")) {
-			LifecycleDefinition<?, ?> lifecycle = (LifecycleDefinition<?, ?>) (rightobjectdefinition
-					.getProperty("LIFECYCLE"));
+			LifecycleDefinition<
+					?, ?> lifecycle = (LifecycleDefinition<?, ?>) (rightobjectdefinition.getProperty("LIFECYCLE"));
 			ExternalFieldSchema<?> rightexternalfield = rightobjectdefinition.generateExternalField(
 					this.getName() + "RIGHTSTATE", "Right object state", "this is a stupid comment", "LIFECYCLE",
 					"STATE", lifecycle.getLifecycleHelper(), rightjoincondition,
@@ -473,11 +495,11 @@ public FieldSchemaForDisplay<E>[] setFieldSchemaToDisplay() {
 		@SuppressWarnings("unchecked")
 		FieldSchemaForDisplay<E>[] returnvalue = new FieldSchemaForDisplay[2];
 		returnvalue[0] = new FieldSchemaForDisplay<E>("Left id",
-				"the technical id generated by the system for the left object of the part", leftid, false, true, -200,
-				16, this.parentobject);
+				"the technical id generated by the system for the left object of the part", leftid, false, true,
+				!makesidmodifiable, -200, 16, this.parentobject);
 		returnvalue[1] = new FieldSchemaForDisplay<E>("Right id",
-				"the technical id generated by the system for the right object of the part", rightid, false, true, -200,
-				16, this.parentobject);
+				"the technical id generated by the system for the right object of the part", rightid, false, true,
+				!makesidmodifiable, -200, 16, this.parentobject);
 
 		return returnvalue;
 	}
@@ -495,8 +517,10 @@ public QueryCondition getUniversalQueryCondition(String alias) {
 	}
 
 	@Override
-	public FlatFileLoaderColumn<E> getFlatFileLoaderColumn(DataObjectDefinition<E> objectdefinition,
-			String[] columnattributes, PropertyExtractor<E> propertyextractor,
+	public FlatFileLoaderColumn<E> getFlatFileLoaderColumn(
+			DataObjectDefinition<E> objectdefinition,
+			String[] columnattributes,
+			PropertyExtractor<E> propertyextractor,
 			ChoiceValue<ApplocaleChoiceDefinition> locale) {
 		throw new RuntimeException("Not yet implemented");
 	}

src/org/openlowcode/server/data/properties/LinkobjectQueryHelper.java

@@ -88,7 +88,7 @@ public <E extends DataObject<E> & LinkobjectInterface<E, F, G>, F extends DataOb
 			TableAlias alias, DataObjectId<F> idvalue, DataObjectDefinition<E> parentobjectdefinition,
 			DataObjectDefinition<F> leftobjectdefinition, DataObjectDefinition<G> rightobjectdefinition) {
 		LinkobjectDefinition<E, F, G> definition = new LinkobjectDefinition<E, F, G>(parentobjectdefinition,
-				leftobjectdefinition, rightobjectdefinition);
+				leftobjectdefinition, rightobjectdefinition, false);
 		@SuppressWarnings("unchecked")
 		StoredFieldSchema<String> id = (StoredFieldSchema<String>) definition.getDefinition().lookupOnName("LFID");
 		if (alias == null)
@@ -112,7 +112,7 @@ public <E extends DataObject<E> & LinkobjectInterface<E, F, G>, F extends DataOb
 			TableAlias alias, DataObjectId<G> idvalue, DataObjectDefinition<E> parentobjectdefinition,
 			DataObjectDefinition<F> leftobjectdefinition, DataObjectDefinition<G> rightobjectdefinition) {
 		LinkobjectDefinition<E, F, G> definition = new LinkobjectDefinition<E, F, G>(parentobjectdefinition,
-				leftobjectdefinition, rightobjectdefinition);
+				leftobjectdefinition, rightobjectdefinition, false);
 		@SuppressWarnings("unchecked")
 		StoredFieldSchema<String> id = (StoredFieldSchema<String>) definition.getDefinition().lookupOnName("RGID");
 		if (alias == null)
@@ -627,7 +627,7 @@ public <E extends DataObject<E> & UniqueidentifiedInterface<E>, F extends DataOb
 					aliaslist.add(additionalcondition.getAliases()[i]);
 
 		LinkobjectDefinition<F, E, G> definition = new LinkobjectDefinition<F, E, G>(linkobjectdefinition,
-				leftobjectdefinition, rightobjectdefinition);
+				leftobjectdefinition, rightobjectdefinition, false);
 		QueryCondition rightidcondition = linkobjectdefinition.extendquery(aliaslist, linkalias,
 				getRightidQueryCondition(linkalias, rightid, linkobjectdefinition, leftobjectdefinition,
 						rightobjectdefinition));