fix: correct RPM package name/version regex split (closes #199)#309
Draft
vmuralictr wants to merge 2 commits into
Draft
fix: correct RPM package name/version regex split (closes #199)#309vmuralictr wants to merge 2 commits into
vmuralictr wants to merge 2 commits into
Conversation
…meproject#199) Signed-off-by: vmuralictr <vmurali.ctr@gmail.com>
vmuralictr
force-pushed
the
fix/rpm-package-regex-issue-199
branch
from
89dafa6 to
4653305
Compare
…oject#199) Replaces the fragile regex split with a proper RPM filename parser based on the approach from PR openmainframeproject#201 by @hbarsaiyan. RPM filenames follow the format: name-version-release.dist.arch The original regex split at the first hyphen before a digit, which broke multi-part names like tzdata-java-2023c-1.fc42.s390x. The new parse_rpm_filename() helper uses rfind to locate the arch, release, and version boundaries from the right, correctly producing: tzdata-java-2023c-1.fc42.s390x -> name=tzdata-java, version=2023c-1 Applied to clefos(), fedora(), almaLinux(), and rockylinux(). Also switches from open()/close() to context managers (with open()).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix RPM package parsing in
bin/package_build.pyso package names and versions are split correctly for Fedora-style package filenames.