Skip to content

Commit 0eafe13

Browse files
committed
Fix thread/proc config in benchmarks.py
1 parent f536964 commit 0eafe13

2 files changed

Lines changed: 6 additions & 7 deletions

File tree

benchmarks/benchmarks.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,27 +8,25 @@
88

99
__all__ = []
1010

11-
for _module_name, (benchmark_name, builder, thread_opts, mpi_opts, custom_metrics) in sorted(
11+
for _module_name, (benchmark_name, builder, configs, custom_metrics) in sorted(
1212
MODEL_REGISTRY.items(), key=lambda item: item[1][0]
1313
):
1414
cls = make_benchmark(
1515
benchmark_name,
1616
builder,
17-
thread_options=thread_opts,
18-
mpi_options=mpi_opts,
17+
configs=configs,
1918
custom_metrics=custom_metrics,
2019
)
2120
globals()[benchmark_name] = cls
2221
__all__.append(benchmark_name)
2322

24-
for _module_name, (benchmark_name, module_path, thread_opts, mpi_opts, custom_metrics, return_metrics) in sorted(
23+
for _module_name, (benchmark_name, module_path, configs, custom_metrics, return_metrics) in sorted(
2524
SCRIPT_REGISTRY.items(), key=lambda item: item[1][0]
2625
):
2726
cls = make_python_benchmark(
2827
benchmark_name,
2928
module_path,
30-
thread_options=thread_opts,
31-
mpi_options=mpi_opts,
29+
configs=configs,
3230
custom_metrics=custom_metrics,
3331
return_metrics=return_metrics,
3432
)

benchmarks/suites/base.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class _BaseBenchmark:
3030
"""Common base for all benchmarks with ``time -v`` metrics."""
3131

3232
params = (_CONFIGS,)
33-
param_names = ("config",)
33+
param_names = ("(threads, mpi_procs)",)
3434
timeout = 600
3535

3636
configs: Tuple[Tuple[int, Optional[int]], ...] = _CONFIGS
@@ -246,6 +246,7 @@ class _PythonBenchmark(_BaseBenchmark):
246246
"""Benchmark that runs arbitrary Python code as a subprocess."""
247247

248248
params = (_PYTHON_DEFAULT_CONFIGS,)
249+
param_names = ("(threads, mpi_procs)",)
249250

250251
configs: Tuple[Tuple[int, Optional[int]], ...] = _PYTHON_DEFAULT_CONFIGS
251252

0 commit comments

Comments
 (0)