fix(custom-currency): fix review comments

Author: borbelyr-kong

api/spec/packages/aip-client-javascript/src/models/schemas.ts

@@ -2781,12 +2781,6 @@ export const currencyCustom = z
     id: ulid,
     code: currencyCodeCustom,
     created_at: dateTime,
-    description: z
-      .string()
-      .min(1)
-      .max(256)
-      .optional()
-      .describe('Description of the currency.'),
   })
   .describe('Describes custom currency.')
 
@@ -2809,12 +2803,6 @@ export const createCurrencyCustomRequest = z
         'The symbol of the currency. It should be a string that represents the symbol of the currency, such as "$" for US Dollar or "€" for Euro.',
       ),
     code: currencyCodeCustom,
-    description: z
-      .string()
-      .min(1)
-      .max(256)
-      .optional()
-      .describe('Description of the currency.'),
   })
   .describe('CurrencyCustom create request.')
 

api/spec/packages/aip-client-javascript/src/models/types.ts

@@ -2092,8 +2092,6 @@ export interface CurrencyCustom {
   code: string
   /** An ISO-8601 timestamp representation of the custom currency creation date. */
   created_at: string
-  /** Description of the currency. */
-  description?: string
 }
 
 /** CurrencyCustom create request. */
@@ -2109,8 +2107,6 @@ export interface CreateCurrencyCustomRequest {
    */
   symbol?: string
   code: string
-  /** Description of the currency. */
-  description?: string
 }
 
 /** Query to evaluate feature access for a list of customers. */

api/spec/packages/aip/src/currencies/currency.tsp

@@ -1,6 +1,5 @@
 import "@typespec/openapi3";
 import "../shared/index.tsp";
-import "./cost-bases/cost-basis.tsp";
 
 namespace Currencies;
 
@@ -110,12 +109,4 @@ model CurrencyCustom {
    */
   @visibility(Lifecycle.Read)
   created_at: Shared.DateTime;
-
-  /**
-   * Description of the currency.
-   */
-  @visibility(Lifecycle.Create, Lifecycle.Read)
-  @minLength(1)
-  @maxLength(256)
-  description?: string;
 }

api/v3/api.gen.go

@@ -33,13 +33,12 @@ func ToAPIBillingCurrency(c currencies.Currency) (v3.BillingCurrency, error) {
 
 	if c.ID != "" {
 		err := out.FromBillingCurrencyCustom(v3.BillingCurrencyCustom{
-			Id:          c.ID,
-			Code:        c.Code,
-			Name:        c.Name,
-			Description: c.Description,
-			Symbol:      c.Symbol,
-			Type:        v3.BillingCurrencyCustomTypeCustom,
-			CreatedAt:   c.CreatedAt,
+			Id:        c.ID,
+			Code:      c.Code,
+			Name:      c.Name,
+			Symbol:    c.Symbol,
+			Type:      v3.BillingCurrencyCustomTypeCustom,
+			CreatedAt: c.CreatedAt,
 		})
 		return out, err
 	}

api/v3/handlers/currencies/convert.go

@@ -5152,11 +5152,6 @@ components:
             - $ref: '#/components/schemas/DateTime'
           description: An ISO-8601 timestamp representation of the custom currency creation date.
           readOnly: true
-        description:
-          type: string
-          minLength: 1
-          maxLength: 256
-          description: Description of the currency.
       additionalProperties: false
       description: Describes custom currency.
     BillingCurrencyFiat:
@@ -8780,11 +8775,6 @@ components:
             the currency, such as "$" for US Dollar or "€" for Euro.
         code:
           $ref: '#/components/schemas/BillingCurrencyCodeCustom'
-        description:
-          type: string
-          minLength: 1
-          maxLength: 256
-          description: Description of the currency.
       additionalProperties: false
       description: CurrencyCustom create request.
     CreateCustomerRequest:

api/v3/openapi.yaml

@@ -6,6 +6,7 @@ import (
 	"time"
 
 	"entgo.io/ent/dialect/sql"
+	"github.com/samber/lo"
 
 	"github.com/openmeterio/openmeter/openmeter/currencies"
 	entdb "github.com/openmeterio/openmeter/openmeter/ent/db"
@@ -17,7 +18,6 @@ import (
 	"github.com/openmeterio/openmeter/pkg/models"
 	"github.com/openmeterio/openmeter/pkg/pagination"
 	"github.com/openmeterio/openmeter/pkg/sortx"
-	"github.com/samber/lo"
 )
 
 var _ currencies.Adapter = (*adapter)(nil)

openmeter/currencies/adapter/currencies.go

@@ -16,10 +16,9 @@ import (
 type Currency struct {
 	models.ManagedModel
 	models.NamespacedID
-	Code        string  `json:"code"`
-	Name        string  `json:"name"`
-	Description *string `json:"description,omitempty"`
-	Symbol      *string `json:"symbol,omitempty"`
+	Code   string  `json:"code"`
+	Name   string  `json:"name"`
+	Symbol *string `json:"symbol,omitempty"`
 }
 
 // OrderBy specifies the field to sort currencies by.