chore: review comments

Author: GAlexIHU

api/v3/handlers/customers/credits/feature_filter_test.go

@@ -53,6 +53,36 @@ func TestFromAPICustomerCreditFeatureFilter(t *testing.T) {
 			filter:  &api.StringFieldFilter{Contains: lo.ToPtr("feature")},
 			wantErr: true,
 		},
+		{
+			name:    "neq is rejected",
+			filter:  &api.StringFieldFilter{Neq: lo.ToPtr("feature-a")},
+			wantErr: true,
+		},
+		{
+			name:    "ocontains is rejected",
+			filter:  &api.StringFieldFilter{Ocontains: []string{"feature"}},
+			wantErr: true,
+		},
+		{
+			name:    "gt is rejected",
+			filter:  &api.StringFieldFilter{Gt: lo.ToPtr("feature-a")},
+			wantErr: true,
+		},
+		{
+			name:    "gte is rejected",
+			filter:  &api.StringFieldFilter{Gte: lo.ToPtr("feature-a")},
+			wantErr: true,
+		},
+		{
+			name:    "lt is rejected",
+			filter:  &api.StringFieldFilter{Lt: lo.ToPtr("feature-a")},
+			wantErr: true,
+		},
+		{
+			name:    "lte is rejected",
+			filter:  &api.StringFieldFilter{Lte: lo.ToPtr("feature-a")},
+			wantErr: true,
+		},
 		{
 			name:    "empty feature is rejected",
 			filter:  &api.StringFieldFilter{Eq: lo.ToPtr("")},

openmeter/billing/charges/creditpurchase/adapter/funded_credit_activity.go

@@ -143,6 +143,9 @@ func fundedCreditActivityFeatureFilterPredicate(filter mo.Option[creditpurchase.
 		return dbchargecreditpurchase.FeatureFiltersIsNil()
 	}
 	features = features.Normalize()
+	if len(features) == 0 {
+		return nil
+	}
 
 	return dbchargecreditpurchase.Or(
 		dbchargecreditpurchase.FeatureFiltersIsNil(),

openmeter/ledger/breakage/adapter/record_test.go

@@ -85,6 +85,19 @@ func TestAdapter_ListExpiredRecordsFiltersByRoute(t *testing.T) {
 			require.ElementsMatch(t, tt.want, recordNames(got))
 		})
 	}
+
+	t.Run("feature match route with input currency", func(t *testing.T) {
+		got, err := a.ListExpiredRecords(t.Context(), breakage.ListExpiredRecordsInput{
+			CustomerID: env.CustomerID,
+			Currency:   &env.Currency,
+			AsOf:       asOf,
+			Route: ledger.RouteFilter{
+				MatchFeature: "feature-a",
+			},
+		})
+		require.NoError(t, err)
+		require.ElementsMatch(t, []string{"unrestricted", "feature-a", "feature-a-b"}, recordNames(got))
+	})
 }
 
 func newExpiredRecord(

openmeter/ledger/customerbalance/service_test.go

@@ -33,6 +33,14 @@ func TestGetBalanceServiceInputValidate(t *testing.T) {
 		FeatureFilter: AllFeatureFilter(),
 	}
 	now := clock.Now()
+	validCursor := ledger.TransactionCursor{
+		BookedAt:  now,
+		CreatedAt: now,
+		ID: models.NamespacedID{
+			Namespace: "ns",
+			ID:        "transaction-id",
+		},
+	}
 
 	tests := []struct {
 		name    string
@@ -89,7 +97,7 @@ func TestGetBalanceServiceInputValidate(t *testing.T) {
 				CustomerID: valid.CustomerID,
 				Currency:   valid.Currency,
 				BalanceQuery: ledger.BalanceQuery{
-					After: &ledger.TransactionCursor{},
+					After: &validCursor,
 					AsOf:  &now,
 				},
 			},