test(e2e): send empty void grant request

Author: GAlexIHU

e2e/customer_credits_v3_test.go

@@ -187,7 +187,7 @@ func TestV3VoidCreditGrant(t *testing.T) {
 
 	// when:
 	// - the first grant is voided
-	status, voided, problem := c.VoidCreditGrant(customerID, grant.Id, nil)
+	status, voided, problem := c.VoidCreditGrant(customerID, grant.Id, apiv3.VoidCreditGrantRequest{})
 	require.Equal(t, http.StatusOK, status, "problem: %+v", problem)
 	require.NotNil(t, voided)
 
@@ -212,7 +212,7 @@ func TestV3VoidCreditGrant(t *testing.T) {
 	})
 
 	t.Run("retrying the void is an idempotent success", func(t *testing.T) {
-		status, again, problem := c.VoidCreditGrant(customerID, grant.Id, nil)
+		status, again, problem := c.VoidCreditGrant(customerID, grant.Id, apiv3.VoidCreditGrantRequest{})
 		require.Equal(t, http.StatusOK, status, "problem: %+v", problem)
 		require.NotNil(t, again)
 		require.Equal(t, apiv3.BillingCreditGrantStatusVoided, again.Status)
@@ -265,7 +265,7 @@ func TestV3VoidCreditGrant(t *testing.T) {
 	})
 
 	t.Run("voiding an unknown grant is a 404", func(t *testing.T) {
-		status, _, problem := c.VoidCreditGrant(customerID, ulid.Make().String(), nil)
+		status, _, problem := c.VoidCreditGrant(customerID, ulid.Make().String(), apiv3.VoidCreditGrantRequest{})
 		require.Equal(t, http.StatusNotFound, status, "problem: %+v", problem)
 	})
 }
@@ -293,7 +293,7 @@ func TestV3VoidCreditGrantPaymentAdjustmentNone(t *testing.T) {
 
 	paymentAdjustment := apiv3.BillingCreditGrantVoidPaymentAdjustmentNone
 
-	status, voided, problem := c.VoidCreditGrant(customer.Id, grant.Id, &apiv3.VoidCreditGrantRequest{
+	status, voided, problem := c.VoidCreditGrant(customer.Id, grant.Id, apiv3.VoidCreditGrantRequest{
 		PaymentAdjustment: &paymentAdjustment,
 	})
 	require.Equal(t, http.StatusOK, status, "problem: %+v", problem)

e2e/v3helpers_test.go

@@ -476,13 +476,8 @@ func (c *v3Client) ListCreditGrantsByStatus(customerID string, grantStatus apiv3
 }
 
 // VoidCreditGrant voids a credit grant, forfeiting the remaining unused balance.
-func (c *v3Client) VoidCreditGrant(customerID, creditGrantID string, body *apiv3.VoidCreditGrantRequest) (int, *apiv3.BillingCreditGrant, *v3Problem) {
-	var requestBody any
-	if body != nil {
-		requestBody = body
-	}
-
-	status, raw, problem := c.do(http.MethodPost, "/customers/"+customerID+"/credits/grants/"+creditGrantID+"/void", requestBody)
+func (c *v3Client) VoidCreditGrant(customerID, creditGrantID string, body apiv3.VoidCreditGrantRequest) (int, *apiv3.BillingCreditGrant, *v3Problem) {
+	status, raw, problem := c.do(http.MethodPost, "/customers/"+customerID+"/credits/grants/"+creditGrantID+"/void", body)
 	return decodeTyped[apiv3.BillingCreditGrant](c, status, raw, problem, http.StatusOK)
 }