Skip to content

Commit 528a770

Browse files
committed
fix(billing): fix review comment
1 parent ad39754 commit 528a770

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

openmeter/billing/service/invoicecalc/taxconfig_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,8 +133,8 @@ func TestSnapshotTaxConfigIntoLines(t *testing.T) {
133133
Stripe: &productcatalog.StripeTaxConfig{Code: "txcd_10000000"},
134134
}),
135135
),
136-
deps: StandardInvoiceCalculatorDependencies{TaxCodes: TaxCodes{"txcd_10000000": tc1}},
137-
wantTC: &billing.TaxConfig{TaxConfig: productcatalog.TaxConfig{Stripe: &productcatalog.StripeTaxConfig{Code: "txcd_10000000"}}},
136+
deps: StandardInvoiceCalculatorDependencies{TaxCodes: TaxCodes{"txcd_10000000": tc1}},
137+
wantTC: &billing.TaxConfig{TaxConfig: productcatalog.TaxConfig{Stripe: &productcatalog.StripeTaxConfig{Code: "txcd_10000000"}}},
138138
wantNoErr: true,
139139
},
140140
{

openmeter/taxcode/taxcode.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,8 @@ type TaxCode struct {
8787
}
8888

8989
// Equal returns true when both TaxCode values carry identical semantic data.
90-
// ManagedModel timestamps (CreatedAt, UpdatedAt, DeletedAt) are excluded; all other fields are compared.
90+
// Compares ID, Namespace, Key, Name, Description, and AppMappings.
91+
// ManagedModel timestamps, Metadata, and Annotations are excluded.
9192
func (t *TaxCode) Equal(v *TaxCode) bool {
9293
if t == nil && v == nil {
9394
return true

0 commit comments

Comments
 (0)