fix: greptile comment

Author: mark-vass-konghq

openmeter/billing/worker/subscriptionsync/service/reconciler/patchcharge_test.go

@@ -269,7 +269,7 @@ func newChargePatchTestExistingIntent(target targetstate.StateItem) chargesusage
 		Intent: chargesmeta.Intent{
 			ManagedBy:         billing.SubscriptionManagedLine,
 			CustomerID:        target.Subscription.CustomerId,
-			Currency:          target.CurrencyCalculator.Currency,
+			Currency:          target.CurrencyCalculator.CurrencyCode(),
 			UniqueReferenceID: ptr("existing-charge"),
 			Subscription: &chargesmeta.SubscriptionReference{
 				SubscriptionID: target.Subscription.ID,

openmeter/billing/worker/subscriptionsync/service/reconciler/patchchargeflatfee.go

@@ -118,7 +118,7 @@ func newFlatFeeChargeIntent(target targetstate.StateItem) (charges.ChargeIntent,
 			ManagedBy:         billing.SubscriptionManagedLine,
 			CustomerID:        target.Subscription.CustomerId,
 			Annotations:       annotations,
-			Currency:          target.CurrencyCalculator.Currency,
+			Currency:          target.CurrencyCalculator.CurrencyCode(),
 			UniqueReferenceID: &target.UniqueID,
 			Subscription: &chargesmeta.SubscriptionReference{
 				SubscriptionID: target.Subscription.ID,

openmeter/billing/worker/subscriptionsync/service/reconciler/patchchargeusagebased.go

@@ -113,7 +113,7 @@ func newUsageBasedChargeIntent(target targetstate.StateItem) (charges.ChargeInte
 			ManagedBy:         billing.SubscriptionManagedLine,
 			CustomerID:        target.Subscription.CustomerId,
 			Annotations:       annotations,
-			Currency:          target.CurrencyCalculator.Currency,
+			Currency:          target.CurrencyCalculator.CurrencyCode(),
 			UniqueReferenceID: &target.UniqueID,
 			Subscription: &chargesmeta.SubscriptionReference{
 				SubscriptionID: target.Subscription.ID,

openmeter/billing/worker/subscriptionsync/service/targetstate/targetstateitem.go

@@ -58,7 +58,7 @@ func (r StateItem) GetExpectedLine() (*billing.GatheringLine, error) {
 				Description: r.Spec.RateCard.AsMeta().Description,
 			}),
 			ManagedBy:              billing.SubscriptionManagedLine,
-			Currency:               r.CurrencyCalculator.Currency,
+			Currency:               r.CurrencyCalculator.CurrencyCode(),
 			ChildUniqueReferenceID: &r.UniqueID,
 			TaxConfig:              r.Spec.RateCard.AsMeta().TaxConfig,
 			ServicePeriod:          r.GetServicePeriod(),

pkg/currencyx/currency_test.go

@@ -103,9 +103,11 @@ func TestCalculatorUsesCurrencyInterface(t *testing.T) {
 	fiatCalculator, err := currencyx.NewCalculator(currencyx.Code("USD"))
 	require.NoError(t, err)
 	require.Equal(t, currencyx.CurrencyTypeFiat, fiatCalculator.CurrencyType())
+	require.Equal(t, currencyx.Code("USD"), fiatCalculator.CurrencyCode())
 	require.Equal(t, int32(2), fiatCalculator.CurrencyPrecision())
 	require.Equal(t, currencyx.RoundingModeHalfAwayFromZero, fiatCalculator.RoundingMode())
-	require.NotNil(t, fiatCalculator.Def)
+	require.NotNil(t, fiatCalculator.Definition())
+	require.Equal(t, "0.01", fiatCalculator.Unit().String())
 	require.Equal(t, float64(1.24), fiatCalculator.RoundToPrecision(alpacadecimal.NewFromFloat(1.235)).InexactFloat64())
 
 	custom, err := currencyx.NewCustomCurrency(currencyx.Code("CREDITS"), 6)
@@ -114,9 +116,10 @@ func TestCalculatorUsesCurrencyInterface(t *testing.T) {
 	customCalculator, err := currencyx.NewCalculator(custom)
 	require.NoError(t, err)
 	require.Equal(t, currencyx.CurrencyTypeCustom, customCalculator.CurrencyType())
+	require.Equal(t, currencyx.Code("CREDITS"), customCalculator.CurrencyCode())
 	require.Equal(t, int32(6), customCalculator.CurrencyPrecision())
 	require.Equal(t, currencyx.RoundingModeBankers, customCalculator.RoundingMode())
-	require.Nil(t, customCalculator.Def)
+	require.Nil(t, customCalculator.Definition())
 	require.Equal(t, float64(1.234568), customCalculator.RoundToPrecision(alpacadecimal.NewFromFloat(1.2345678)).InexactFloat64())
 }
 

pkg/currencyx/fiat.go

@@ -31,8 +31,8 @@ func (c Code) Calculator() (Calculator, error) {
 }
 
 type Calculator struct {
-	Currency     Code
-	Def          *currency.Def
+	currency     Code
+	def          *currency.Def
 	currencyType CurrencyType
 	precision    int32
 	roundingMode RoundingMode
@@ -60,8 +60,8 @@ func NewCalculator(cur Currency) (Calculator, error) {
 		}
 
 		return Calculator{
-			Currency:     code,
-			Def:          def,
+			currency:     code,
+			def:          def,
 			currencyType: CurrencyTypeFiat,
 			precision:    int32(def.Subunits),
 			roundingMode: RoundingModeHalfAwayFromZero,
@@ -80,7 +80,7 @@ func NewCalculator(cur Currency) (Calculator, error) {
 		}
 
 		return Calculator{
-			Currency:     code,
+			currency:     code,
 			currencyType: CurrencyTypeCustom,
 			precision:    precision,
 			roundingMode: roundingMode,
@@ -90,6 +90,14 @@ func NewCalculator(cur Currency) (Calculator, error) {
 	}
 }
 
+func (c Calculator) CurrencyCode() Code {
+	return c.currency
+}
+
+func (c Calculator) Definition() *currency.Def {
+	return c.def
+}
+
 func (c Calculator) CurrencyType() CurrencyType {
 	return c.currencyType
 }
@@ -126,17 +134,17 @@ func (c Calculator) Validate() error {
 
 	switch c.currencyType {
 	case CurrencyTypeFiat:
-		if err := c.Currency.Validate(); err != nil {
+		if err := c.currency.Validate(); err != nil {
 			errs = append(errs, err)
 		}
-		if c.Def == nil {
+		if c.def == nil {
 			errs = append(errs, errors.New("fiat currency definition is required"))
 		}
-		if c.Def != nil && c.precision != int32(c.Def.Subunits) {
+		if c.def != nil && c.precision != int32(c.def.Subunits) {
 			errs = append(errs, errors.New("fiat currency precision must match currency definition"))
 		}
 	case CurrencyTypeCustom:
-		if err := c.Currency.ValidateCustom(); err != nil {
+		if err := c.currency.ValidateCustom(); err != nil {
 			errs = append(errs, err)
 		}
 		if err := validatePrecision(c.precision); err != nil {
@@ -146,7 +154,7 @@ func (c Calculator) Validate() error {
 			errs = append(errs, err)
 		}
 	default:
-		if c.Currency == "" {
+		if c.currency == "" {
 			errs = append(errs, errors.New("currency code is required"))
 		}
 		errs = append(errs, c.currencyType.Validate())