@@ -29,7 +29,7 @@ type fieldFiltersTarget struct {
2929 StringExact * filters.FilterStringExact `json:"string_exact,omitempty"`
3030 ULID * filters.FilterULID `json:"ulid,omitempty"`
3131 DateTime * filters.FilterDateTime `json:"datetime,omitempty"`
32- Labels * filters.FilterString `json:"labels,omitempty"`
32+ Labels * filters.FilterLabels `json:"labels,omitempty"`
3333}
3434
3535// validatorErrorResponse mirrors the AIP-style error body produced by
@@ -480,13 +480,13 @@ func TestFieldFilterParse(t *testing.T) {
480480 // fixture wires the labels field as a single filter, not a labels map.
481481 {
482482 name : "labels short" ,
483- query : "filter[labels]=team-a" ,
484- wantParse : fieldFiltersTarget {Labels : & filters.FilterString { Eq : lo .ToPtr ("team-a" )}},
483+ query : "filter[labels][key] =team-a" ,
484+ wantParse : fieldFiltersTarget {Labels : & filters.FilterLabels { "key" : { Eq : lo .ToPtr ("team-a" )} }},
485485 },
486486 {
487487 name : "labels contains" ,
488- query : "filter[labels][contains]=team" ,
489- wantParse : fieldFiltersTarget {Labels : & filters.FilterString { Contains : lo .ToPtr ("team" )}},
488+ query : "filter[labels][key][ contains]=team" ,
489+ wantParse : fieldFiltersTarget {Labels : & filters.FilterLabels { "key" : { Contains : lo .ToPtr ("team" )} }},
490490 },
491491
492492 // Multiple independent filters in one request.
@@ -501,11 +501,11 @@ func TestFieldFilterParse(t *testing.T) {
501501 },
502502 {
503503 name : "combined ulid+datetime+labels" ,
504- query : "filter[ulid][eq]=" + ulid1 + "&filter[datetime][lt]=2024-01-02T03:04:05Z&filter[labels]=team-a" ,
504+ query : "filter[ulid][eq]=" + ulid1 + "&filter[datetime][lt]=2024-01-02T03:04:05Z&filter[labels][key] =team-a" ,
505505 wantParse : fieldFiltersTarget {
506506 ULID : & filters.FilterULID {Eq : & ulid1 },
507507 DateTime : & filters.FilterDateTime {Lt : & dt },
508- Labels : & filters.FilterString { Eq : lo .ToPtr ("team-a" )},
508+ Labels : & filters.FilterLabels { "key" : { Eq : lo .ToPtr ("team-a" )} },
509509 },
510510 },
511511
0 commit comments