feat(api): added listing handler without filtering and package and dynamic prices filtered out

Author: rolosp

api/v3/handlers/plans/convert.go

@@ -16,6 +16,28 @@ import (
 	"github.com/openmeterio/openmeter/pkg/models"
 )
 
+var unsupportedV3PriceTypes = map[productcatalog.PriceType]struct{}{
+	productcatalog.DynamicPriceType: {},
+	productcatalog.PackagePriceType: {},
+}
+
+func hasUnsupportedV3Price(p plan.Plan) bool {
+	for _, phase := range p.Phases {
+		for _, rc := range phase.RateCards {
+			price := rc.AsMeta().Price
+			if price == nil {
+				continue
+			}
+
+			if _, unsupported := unsupportedV3PriceTypes[price.Type()]; unsupported {
+				return true
+			}
+		}
+	}
+
+	return false
+}
+
 func FromPlan(p plan.Plan) (api.BillingPlan, error) {
 	validationIssues, _ := p.AsProductCatalogPlan().ValidationErrors()
 

api/v3/handlers/plans/handler.go

@@ -8,6 +8,7 @@ import (
 )
 
 type Handler interface {
+	ListPlans() ListPlansHandler
 	GetPlan() GetPlanHandler
 	CreatePlan() CreatePlanHandler
 	UpdatePlan() UpdatePlanHandler

api/v3/handlers/plans/list.go

@@ -0,0 +1,90 @@
+package plans
+
+import (
+	"context"
+	"net/http"
+
+	"github.com/samber/lo"
+
+	api "github.com/openmeterio/openmeter/api/v3"
+	"github.com/openmeterio/openmeter/api/v3/apierrors"
+	"github.com/openmeterio/openmeter/api/v3/response"
+	"github.com/openmeterio/openmeter/openmeter/productcatalog/plan"
+	"github.com/openmeterio/openmeter/pkg/framework/commonhttp"
+	"github.com/openmeterio/openmeter/pkg/framework/transport/httptransport"
+	"github.com/openmeterio/openmeter/pkg/pagination"
+)
+
+type (
+	ListPlansRequest  = plan.ListPlansInput
+	ListPlansResponse = response.PagePaginationResponse[api.BillingPlan]
+	ListPlansParams   = api.ListPlansParams
+	ListPlansHandler  httptransport.HandlerWithArgs[ListPlansRequest, ListPlansResponse, ListPlansParams]
+)
+
+func (h *handler) ListPlans() ListPlansHandler {
+	return httptransport.NewHandlerWithArgs(
+		func(ctx context.Context, r *http.Request, params ListPlansParams) (ListPlansRequest, error) {
+			ns, err := h.resolveNamespace(ctx)
+			if err != nil {
+				return ListPlansRequest{}, err
+			}
+
+			page := pagination.NewPage(1, 20)
+			if params.Page != nil {
+				page = pagination.NewPage(
+					lo.FromPtrOr(params.Page.Number, 1),
+					lo.FromPtrOr(params.Page.Size, 20),
+				)
+			}
+
+			if err := page.Validate(); err != nil {
+				return ListPlansRequest{}, apierrors.NewBadRequestError(ctx, err, apierrors.InvalidParameters{
+					apierrors.InvalidParameter{
+						Field:  "page",
+						Reason: err.Error(),
+						Source: apierrors.InvalidParamSourceQuery,
+					},
+				})
+			}
+
+			return ListPlansRequest{
+				Namespaces: []string{ns},
+				Page:       page,
+			}, nil
+		},
+		func(ctx context.Context, req ListPlansRequest) (ListPlansResponse, error) {
+			result, err := h.service.ListPlans(ctx, req)
+			if err != nil {
+				return ListPlansResponse{}, err
+			}
+
+			items := make([]api.BillingPlan, 0, len(result.Items))
+			for _, p := range result.Items {
+				// FIXME: For now we skip plans containing price types not representable in v3 (e.g., package, dynamic). We'll add full bidirectional transform later on.
+				if hasUnsupportedV3Price(p) {
+					continue
+				}
+
+				billingPlan, err := FromPlan(p)
+				if err != nil {
+					return ListPlansResponse{}, err
+				}
+
+				items = append(items, billingPlan)
+			}
+
+			return response.NewPagePaginationResponse(items, response.PageMetaPage{
+				Size:   req.Page.PageSize,
+				Number: req.Page.PageNumber,
+				Total:  lo.ToPtr(result.TotalCount),
+			}), nil
+		},
+		commonhttp.JSONResponseEncoderWithStatus[ListPlansResponse](http.StatusOK),
+		httptransport.AppendOptions(
+			h.options,
+			httptransport.WithOperationName("list-plans"),
+			httptransport.WithErrorEncoder(apierrors.GenericErrorEncoder()),
+		)...,
+	)
+}

api/v3/server/routes.go

@@ -239,7 +239,7 @@ func (s *Server) DeleteLlmCostOverride(w http.ResponseWriter, r *http.Request, p
 // Plans
 
 func (s *Server) ListPlans(w http.ResponseWriter, r *http.Request, params api.ListPlansParams) {
-	unimplemented.ListPlans(w, r, params)
+	s.plansHandler.ListPlans().With(params).ServeHTTP(w, r)
 }
 
 func (s *Server) CreatePlan(w http.ResponseWriter, r *http.Request) {