feat(api): for now return conflict errors for package and dynamic pricing

Author: rolosp

api/v3/handlers/plans/convert.go

@@ -210,10 +210,10 @@ func fromBillingPrice(p *productcatalog.Price) (api.BillingPrice, error) {
 		}
 
 	case productcatalog.DynamicPriceType:
-		return result, fmt.Errorf("dynamic price is not supported in v3 API")
+		return result, models.NewGenericConflictError(fmt.Errorf("dynamic price is not supported in v3 API"))
 
 	case productcatalog.PackagePriceType:
-		return result, fmt.Errorf("package price is not supported in v3 API")
+		return result, models.NewGenericConflictError(fmt.Errorf("package price is not supported in v3 API"))
 
 	default:
 		return result, fmt.Errorf("unknown price type: %s", p.Type())

api/v3/handlers/plans/convert_test.go

@@ -531,22 +531,24 @@ func TestFromBillingPrice(t *testing.T) {
 		assert.Equal(t, "volume", disc)
 	})
 
-	t.Run("dynamic price returns error", func(t *testing.T) {
+	t.Run("dynamic price returns conflict error", func(t *testing.T) {
 		p := productcatalog.NewPriceFrom(productcatalog.DynamicPrice{})
 
 		_, err := fromBillingPrice(p)
 		require.Error(t, err)
+		assert.True(t, models.IsGenericConflictError(err))
 		assert.Contains(t, err.Error(), "dynamic price is not supported in v3 API")
 	})
 
-	t.Run("package price returns error", func(t *testing.T) {
+	t.Run("package price returns conflict error", func(t *testing.T) {
 		p := productcatalog.NewPriceFrom(productcatalog.PackagePrice{
 			Amount:             decimal.NewFromFloat(10),
 			QuantityPerPackage: decimal.NewFromInt(100),
 		})
 
 		_, err := fromBillingPrice(p)
 		require.Error(t, err)
+		assert.True(t, models.IsGenericConflictError(err))
 		assert.Contains(t, err.Error(), "package price is not supported in v3 API")
 	})
 }