Skip to content

Commit cb75a2f

Browse files
authored
fix(api): v3 resource mixin required created_at and updated_at (#4295)
1 parent 6ab8a47 commit cb75a2f

30 files changed

Lines changed: 803 additions & 816 deletions

File tree

api/spec/packages/aip/src/currencies/cost-bases/cost-basis.tsp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,5 +34,5 @@ model CostBasis {
3434
* An ISO-8601 timestamp representation of entity creation date.
3535
*/
3636
@visibility(Lifecycle.Read)
37-
created_at?: Shared.DateTime;
37+
created_at: Shared.DateTime;
3838
}

api/spec/packages/aip/src/currencies/currency.tsp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,5 +114,5 @@ model CurrencyCustom {
114114
* An ISO-8601 timestamp representation of the custom currency creation date.
115115
*/
116116
@visibility(Lifecycle.Read)
117-
created_at?: Shared.DateTime;
117+
created_at: Shared.DateTime;
118118
}

api/spec/packages/aip/src/customers/charges/operations.tsp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,10 @@ interface CustomerChargesOperations {
6868
filter?: ListCustomerChargesParamsFilter,
6969

7070
/**
71-
* Expands
71+
* Expand full objects for referenced entities.
72+
*
73+
* Supported values are:
74+
* - `real_time_usage`: Expand the charge's real-time usage.
7275
*/
7376
@query(#{ name: "expand", explode: true })
7477
expand?: ChargesExpand[],

api/spec/packages/aip/src/customers/credits/operations.tsp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -141,11 +141,6 @@ model GetCreditBalanceParamsFilter {
141141
* Filter credit balance by currency.
142142
*/
143143
currency?: Currencies.CurrencyCode;
144-
145-
/**
146-
* Filter by specific feature.
147-
*/
148-
feature?: Shared.ResourceKey;
149144
}
150145

151146
interface CustomerCreditBalancesOperations {

api/spec/packages/aip/src/events/operations.tsp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ interface EventsOperations {
7272
* List ingested events.
7373
*/
7474
@extension(Shared.UnstableExtension, true)
75-
@extension(Shared.PrivateExtension, true)
75+
@extension(Shared.InternalExtension, true)
7676
@get
7777
@operationId("list-metering-events")
7878
@summary("List metering events")

api/spec/packages/aip/src/features/operations.tsp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ interface FeatureOperations {
3434
@operationId("list-features")
3535
@summary("List features")
3636
@extension(Shared.UnstableExtension, true)
37-
@extension(Shared.PrivateExtension, true)
37+
@extension(Shared.InternalExtension, true)
3838
list(
3939
...Common.PagePaginationQuery,
4040

@@ -68,7 +68,7 @@ interface FeatureOperations {
6868
@operationId("create-feature")
6969
@summary("Create feature")
7070
@extension(Shared.UnstableExtension, true)
71-
@extension(Shared.PrivateExtension, true)
71+
@extension(Shared.InternalExtension, true)
7272
create(
7373
@body
7474
feature: Shared.CreateRequest<Feature>,
@@ -82,7 +82,7 @@ interface FeatureOperations {
8282
@operationId("get-feature")
8383
@summary("Get feature")
8484
@extension(Shared.UnstableExtension, true)
85-
@extension(Shared.PrivateExtension, true)
85+
@extension(Shared.InternalExtension, true)
8686
get(@path featureId: Shared.ULID):
8787
| Shared.GetResponse<Feature>
8888
| Common.ErrorResponses
@@ -98,7 +98,7 @@ interface FeatureOperations {
9898
@operationId("update-feature")
9999
@summary("Update feature")
100100
@extension(Shared.UnstableExtension, true)
101-
@extension(Shared.PrivateExtension, true)
101+
@extension(Shared.InternalExtension, true)
102102
update(
103103
@path featureId: Shared.ULID,
104104
@body feature: FeatureUpdateRequest,
@@ -112,7 +112,7 @@ interface FeatureOperations {
112112
@operationId("delete-feature")
113113
@summary("Delete feature")
114114
@extension(Shared.UnstableExtension, true)
115-
@extension(Shared.PrivateExtension, true)
115+
@extension(Shared.InternalExtension, true)
116116
delete(
117117
@path featureId: Shared.ULID,
118118
): Shared.DeleteResponse | Common.ErrorResponses | Common.NotFound;
@@ -123,7 +123,7 @@ interface FeatureCostOperations {
123123
* Query the cost of a feature.
124124
*/
125125
@extension(Shared.UnstableExtension, true)
126-
@extension(Shared.PrivateExtension, true)
126+
@extension(Shared.InternalExtension, true)
127127
@post
128128
@route("/query")
129129
@operationId("query-feature-cost")

api/spec/packages/aip/src/llmcost/prices.tsp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,11 @@ model Price {
7777

7878
/** Creation timestamp. */
7979
@visibility(Lifecycle.Read)
80-
created_at?: Shared.DateTime;
80+
created_at: Shared.DateTime;
8181

8282
/** Last update timestamp. */
8383
@visibility(Lifecycle.Read)
84-
updated_at?: Shared.DateTime;
84+
updated_at: Shared.DateTime;
8585
}
8686

8787
/**

api/spec/packages/aip/src/meters/operations.tsp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ interface MetersOperations {
8888
* Update a meter.
8989
*/
9090
@extension(Shared.UnstableExtension, true)
91-
@extension(Shared.PrivateExtension, true)
91+
@extension(Shared.InternalExtension, true)
9292
@put
9393
@operationId("update-meter")
9494
@summary("Update meter")
@@ -124,7 +124,7 @@ interface MetersQueryOperations {
124124
* is in the query's `group_by_dimensions`.
125125
*/
126126
@extension(Shared.UnstableExtension, true)
127-
@extension(Shared.PrivateExtension, true)
127+
@extension(Shared.InternalExtension, true)
128128
@post
129129
@operationId("query-meter")
130130
@summary("Query meter")
@@ -136,7 +136,7 @@ interface MetersQueryOperations {
136136

137137
#suppress "@openmeter/api-spec-aip/operation-summary" "Avoid duplicating the summary in OpenAPI yaml"
138138
@extension(Shared.UnstableExtension, true)
139-
@extension(Shared.PrivateExtension, true)
139+
@extension(Shared.InternalExtension, true)
140140
@opExample(
141141
#{
142142
returnType: #{

api/spec/packages/aip/src/productcatalog/operations.tsp

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ interface PlanOperations {
3838
@operationId("list-plans")
3939
@summary("List plans")
4040
@extension(Shared.UnstableExtension, true)
41-
@extension(Shared.PrivateExtension, true)
41+
@extension(Shared.InternalExtension, true)
4242
listPlans(
4343
...Common.PagePaginationQuery,
4444

@@ -68,7 +68,7 @@ interface PlanOperations {
6868
@operationId("create-plan")
6969
@summary("Create plan")
7070
@extension(Shared.UnstableExtension, true)
71-
@extension(Shared.PrivateExtension, true)
71+
@extension(Shared.InternalExtension, true)
7272
createPlan(
7373
@body plan: Shared.CreateRequest<Plan>,
7474
): Shared.CreateResponse<Plan> | Common.ErrorResponses;
@@ -81,7 +81,7 @@ interface PlanOperations {
8181
@operationId("update-plan")
8282
@summary("Update plan")
8383
@extension(Shared.UnstableExtension, true)
84-
@extension(Shared.PrivateExtension, true)
84+
@extension(Shared.InternalExtension, true)
8585
updatePlan(
8686
@path planId: Shared.ULID,
8787
@body plan: Shared.UpsertRequest<Plan>,
@@ -99,7 +99,7 @@ interface PlanOperations {
9999
@operationId("get-plan")
100100
@summary("Get plan")
101101
@extension(Shared.UnstableExtension, true)
102-
@extension(Shared.PrivateExtension, true)
102+
@extension(Shared.InternalExtension, true)
103103
getPlan(@path planId: Shared.ULID):
104104
| Shared.GetResponse<Plan>
105105
| Common.ErrorResponses
@@ -114,7 +114,7 @@ interface PlanOperations {
114114
@operationId("delete-plan")
115115
@summary("Delete plan")
116116
@extension(Shared.UnstableExtension, true)
117-
@extension(Shared.PrivateExtension, true)
117+
@extension(Shared.InternalExtension, true)
118118
deletePlan(
119119
@path planId: Shared.ULID,
120120
): Shared.DeleteResponse | Common.ErrorResponses | Common.NotFound;
@@ -127,7 +127,7 @@ interface PlanOperations {
127127
@operationId("archive-plan")
128128
@summary("Archive plan version")
129129
@extension(Shared.UnstableExtension, true)
130-
@extension(Shared.PrivateExtension, true)
130+
@extension(Shared.InternalExtension, true)
131131
archivePlan(
132132
@path planId: Shared.ULID,
133133
): Shared.UpdateResponse<Plan> | Common.ErrorResponses | Common.NotFound;
@@ -140,7 +140,7 @@ interface PlanOperations {
140140
@operationId("publish-plan")
141141
@summary("Publish plan version")
142142
@extension(Shared.UnstableExtension, true)
143-
@extension(Shared.PrivateExtension, true)
143+
@extension(Shared.InternalExtension, true)
144144
publishPlan(
145145
@path planId: Shared.ULID,
146146
): Shared.UpdateResponse<Plan> | Common.ErrorResponses | Common.NotFound;
@@ -171,7 +171,7 @@ interface AddonOperations {
171171
@operationId("list-addons")
172172
@summary("List add-ons")
173173
@extension(Shared.UnstableExtension, true)
174-
@extension(Shared.PrivateExtension, true)
174+
@extension(Shared.InternalExtension, true)
175175
listAddons(
176176
...Common.PagePaginationQuery,
177177

@@ -204,7 +204,7 @@ interface AddonOperations {
204204
@operationId("create-addon")
205205
@summary("Create add-on")
206206
@extension(Shared.UnstableExtension, true)
207-
@extension(Shared.PrivateExtension, true)
207+
@extension(Shared.InternalExtension, true)
208208
createAddon(
209209
@body addon: Shared.CreateRequest<Addon>,
210210
): Shared.CreateResponse<Addon> | Common.ErrorResponses;
@@ -217,7 +217,7 @@ interface AddonOperations {
217217
@operationId("update-addon")
218218
@summary("Update add-on")
219219
@extension(Shared.UnstableExtension, true)
220-
@extension(Shared.PrivateExtension, true)
220+
@extension(Shared.InternalExtension, true)
221221
updateAddon(
222222
@path addonId: Shared.ULID,
223223
@body addon: Shared.UpsertRequest<Addon>,
@@ -235,7 +235,7 @@ interface AddonOperations {
235235
@operationId("get-addon")
236236
@summary("Get add-on")
237237
@extension(Shared.UnstableExtension, true)
238-
@extension(Shared.PrivateExtension, true)
238+
@extension(Shared.InternalExtension, true)
239239
getAddon(@path addonId: Shared.ULID):
240240
| Shared.GetResponse<Addon>
241241
| Common.ErrorResponses
@@ -250,7 +250,7 @@ interface AddonOperations {
250250
@operationId("delete-addon")
251251
@summary("Soft delete add-on")
252252
@extension(Shared.UnstableExtension, true)
253-
@extension(Shared.PrivateExtension, true)
253+
@extension(Shared.InternalExtension, true)
254254
deleteAddon(
255255
@path addonId: Shared.ULID,
256256
): Shared.DeleteResponse | Common.ErrorResponses | Common.NotFound;
@@ -263,7 +263,7 @@ interface AddonOperations {
263263
@operationId("archive-addon")
264264
@summary("Archive add-on version")
265265
@extension(Shared.UnstableExtension, true)
266-
@extension(Shared.PrivateExtension, true)
266+
@extension(Shared.InternalExtension, true)
267267
archiveAddon(
268268
@path addonId: Shared.ULID,
269269
): Shared.UpdateResponse<Addon> | Common.ErrorResponses | Common.NotFound;
@@ -276,7 +276,7 @@ interface AddonOperations {
276276
@operationId("publish-addon")
277277
@summary("Publish add-on version")
278278
@extension(Shared.UnstableExtension, true)
279-
@extension(Shared.PrivateExtension, true)
279+
@extension(Shared.InternalExtension, true)
280280
publishAddon(
281281
@path addonId: Shared.ULID,
282282
): Shared.UpdateResponse<Addon> | Common.ErrorResponses | Common.NotFound;
@@ -290,7 +290,7 @@ interface PlanAddonOperations {
290290
@operationId("list-plan-addons")
291291
@summary("List add-ons for plan")
292292
@extension(Shared.UnstableExtension, true)
293-
@extension(Shared.PrivateExtension, true)
293+
@extension(Shared.InternalExtension, true)
294294
listPlanAddons(
295295
@path planId: Shared.ULID,
296296
...Common.PagePaginationQuery,
@@ -303,7 +303,7 @@ interface PlanAddonOperations {
303303
@operationId("create-plan-addon")
304304
@summary("Add add-on to plan")
305305
@extension(Shared.UnstableExtension, true)
306-
@extension(Shared.PrivateExtension, true)
306+
@extension(Shared.InternalExtension, true)
307307
createPlanAddon(
308308
@path planId: Shared.ULID,
309309
@body plan_addon: Shared.CreateRequest<PlanAddon>,
@@ -317,7 +317,7 @@ interface PlanAddonOperations {
317317
@operationId("get-plan-addon")
318318
@summary("Get add-on association for plan")
319319
@extension(Shared.UnstableExtension, true)
320-
@extension(Shared.PrivateExtension, true)
320+
@extension(Shared.InternalExtension, true)
321321
getPlanAddon(
322322
@path planId: Shared.ULID,
323323
@path planAddonId: Shared.ULID,
@@ -331,7 +331,7 @@ interface PlanAddonOperations {
331331
@operationId("update-plan-addon")
332332
@summary("Update add-on association for plan")
333333
@extension(Shared.UnstableExtension, true)
334-
@extension(Shared.PrivateExtension, true)
334+
@extension(Shared.InternalExtension, true)
335335
updatePlanAddon(
336336
@path planId: Shared.ULID,
337337
@path planAddonId: Shared.ULID,
@@ -346,7 +346,7 @@ interface PlanAddonOperations {
346346
@operationId("delete-plan-addon")
347347
@summary("Remove add-on from plan")
348348
@extension(Shared.UnstableExtension, true)
349-
@extension(Shared.PrivateExtension, true)
349+
@extension(Shared.InternalExtension, true)
350350
deletePlanAddon(
351351
@path planId: Shared.ULID,
352352
@path planAddonId: Shared.ULID,

api/spec/packages/aip/src/productcatalog/plan.tsp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,8 @@ model Plan {
5959

6060
/**
6161
* Whether pro-rating is enabled for this plan.
62-
*
63-
* TODO: WIP — pro-rating mode and exact semantics will be defined in a later iteration.
6462
*/
63+
// TODO: WIP — pro-rating mode and exact semantics will be defined in a later iteration.
6564
@visibility(Lifecycle.Read, Lifecycle.Create, Lifecycle.Update)
6665
@summary("Pro-rating enabled")
6766
pro_rating_enabled?: boolean = true;

0 commit comments

Comments
 (0)