fix: rabbit comment and tests

Author: mark-vass-konghq

openmeter/currencies/service/service_test.go

@@ -2,6 +2,7 @@ package service
 
 import (
 	"context"
+	"errors"
 	"testing"
 	"time"
 
@@ -51,19 +52,19 @@ func (f *fakeAdapter) ListCustomCurrencies(_ context.Context, params currencies.
 }
 
 func (f *fakeAdapter) CreateCurrency(_ context.Context, _ currencies.CreateCurrencyInput) (currencies.Currency, error) {
-	panic("not implemented")
+	return currencies.Currency{}, errors.New("fakeAdapter.CreateCurrency is not implemented")
 }
 
 func (f *fakeAdapter) CreateCostBasis(ctx context.Context, input currencies.CreateCostBasisInput) (currencies.CostBasis, error) {
 	if f.createCostBasis != nil {
 		return f.createCostBasis(ctx, input)
 	}
 
-	panic("not implemented")
+	return currencies.CostBasis{}, errors.New("fakeAdapter.CreateCostBasis is not implemented")
 }
 
 func (f *fakeAdapter) ListCostBases(_ context.Context, _ currencies.ListCostBasesInput) (pagination.Result[currencies.CostBasis], error) {
-	panic("not implemented")
+	return pagination.Result[currencies.CostBasis]{}, errors.New("fakeAdapter.ListCostBases is not implemented")
 }
 
 // newTestService creates a Service backed by a fake adapter seeded with custom currencies.

pkg/currencyx/fiat.go

@@ -61,7 +61,7 @@ func NewCalculator(cur Currency) (Calculator, error) {
 		}
 
 		def := currency.Get(currency.Code(code))
-		if def == nil {
+		if def == nil || def.ISONumeric == "" {
 			return Calculator{}, fmt.Errorf("fiat currency definition is required for %s", code)
 		}
 
@@ -143,8 +143,8 @@ func (c Calculator) Validate() error {
 		if err := c.currency.Validate(); err != nil {
 			errs = append(errs, err)
 		}
-		if c.def == nil {
-			errs = append(errs, errors.New("fiat currency definition is required"))
+		if c.def == nil || c.def.ISONumeric == "" {
+			errs = append(errs, fmt.Errorf("fiat currency definition is required for %s", c.currency))
 		}
 		if c.def != nil && c.precision != int32(c.def.Subunits) {
 			errs = append(errs, errors.New("fiat currency precision must match currency definition"))

pkg/currencyx/fiat_test.go

@@ -0,0 +1,37 @@
+package currencyx
+
+import (
+	"testing"
+
+	"github.com/invopop/gobl/currency"
+	"github.com/stretchr/testify/require"
+
+	"github.com/openmeterio/openmeter/pkg/models"
+)
+
+func TestNewCalculatorRequiresISOFiatDefinition(t *testing.T) {
+	calculator, err := NewCalculator(Code("USD"))
+	require.NoError(t, err)
+	require.Equal(t, Code("USD"), calculator.CurrencyCode())
+
+	_, err = NewCalculator(Code("BTC"))
+	require.Error(t, err)
+	require.Contains(t, err.Error(), "fiat currency definition is required for BTC")
+}
+
+func TestCalculatorValidateRequiresISOFiatDefinition(t *testing.T) {
+	def := currency.Get(currency.Code("BTC"))
+	require.NotNil(t, def)
+	require.Empty(t, def.ISONumeric)
+
+	err := Calculator{
+		currency:     Code("BTC"),
+		def:          def,
+		currencyType: CurrencyTypeFiat,
+		precision:    int32(def.Subunits),
+		roundingMode: RoundingModeHalfAwayFromZero,
+	}.Validate()
+	require.Error(t, err)
+	require.True(t, models.IsGenericValidationError(err), "error must be a validation error")
+	require.Contains(t, err.Error(), "fiat currency definition is required for BTC")
+}