fix: filter mapping

Author: tothandras

api/v3/handlers/customers/credits/convert.go

@@ -239,19 +239,19 @@ func convertAPITaxConfig(tc *api.BillingCreditGrantTaxConfig) *productcatalog.Ta
 	return config
 }
 
-func convertAPIStatusToChargeStatus(status api.BillingCreditGrantStatus) meta.ChargeStatus {
+func convertAPIStatusToChargeStatus(status api.BillingCreditGrantStatus) (meta.ChargeStatus, error) {
 	switch status {
 	case api.BillingCreditGrantStatusActive:
-		return meta.ChargeStatusActive
+		return meta.ChargeStatusActive, nil
 	case api.BillingCreditGrantStatusPending:
-		return meta.ChargeStatusCreated
+		return meta.ChargeStatusCreated, nil
 	case api.BillingCreditGrantStatusVoided:
-		return meta.ChargeStatusDeleted
+		return meta.ChargeStatusDeleted, nil
 	case api.BillingCreditGrantStatusExpired:
 		// Expired maps to final (terminal state, no further actions).
-		return meta.ChargeStatusFinal
+		return meta.ChargeStatusFinal, nil
 	default:
-		return meta.ChargeStatus(status)
+		return "", fmt.Errorf("unsupported credit grant status: %s", status)
 	}
 }
 

api/v3/handlers/customers/credits/list_grants.go

@@ -63,7 +63,16 @@ func (h *handler) ListCreditGrants() ListCreditGrantsHandler {
 
 			if args.Params.Filter != nil {
 				if args.Params.Filter.Status != nil {
-					status := convertAPIStatusToChargeStatus(*args.Params.Filter.Status)
+					status, err := convertAPIStatusToChargeStatus(*args.Params.Filter.Status)
+					if err != nil {
+						return ListCreditGrantsRequest{}, apierrors.NewBadRequestError(ctx, err, apierrors.InvalidParameters{
+							{
+								Field:  "filter[status]",
+								Reason: err.Error(),
+								Source: apierrors.InvalidParamSourceQuery,
+							},
+						})
+					}
 					req.Status = &status
 				}