-
Notifications
You must be signed in to change notification settings - Fork 199
feat: credit balances final #4559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
72a203f
feat: add effectiveAt to creditgrant
GAlexIHU 3547384
feat(ledger): pending balance
GAlexIHU 01a8168
test: customerbalance pending
GAlexIHU 357d8b7
fix: pr comments
GAlexIHU def608c
test(ledger): align credit purchase intent fixtures
GAlexIHU 9818aa0
fix: align credit balance tests
GAlexIHU 3aeb6db
fix: align e2e pending balance expectation
GAlexIHU a2b74a4
fix: pending grant asof
GAlexIHU File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
availableremoved andpendingsemantics silently redefinedThe old
CreditBalanceexposedavailable(consumable right now) andpending(awaiting payment / future effective). This PR removesavailableentirely and reuses the field namependingfor a different concept (not-yet-ledger-booked grants). Any client currently readingavailablewill getnull/missing, and any client readingpendingwill get a value with entirely different meaning. If this API is consumed by external clients or SDKs, a versioned deprecation or at minimum an explicit changelog entry is needed before merging.