[codex] clarify agent guidance ownership - #4574
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. Warning Ignoring CodeRabbit configuration file changes. For security, only the configuration from the base branch is applied for open source repositories. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR updates repository guidance in AGENTS.md and api/spec/AGENTS.md, adds review instructions for skill docs, and revises two skill docs for billing adapter transaction handling and samber-lo usage. ChangesRepository guidance
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
turip
marked this pull request as ready for review
June 25, 2026 19:04
turip
added
the
release-note/ignore
tothandras
previously approved these changes
Jun 25, 2026
Contributor
Greptile SummaryThis PR clarifies how repository guidance should be owned and maintained. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (5): Last reviewed commit: "Merge branch 'main' into feat/agent-guid..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.agents/skills/charges/SKILL.md:
- Around line 68-71: Clarify the adapter transaction guidance so it is
actionable for helpers under openmeter/billing/charges/.../adapter: state that
shared helper functions must use the transaction-aware repo/adapter handle from
ctx rather than relying on a raw *entdb.Client being “rebound” by
TransactingRepo/TransactingRepoWithNoValue. Update the wording around the
affected helper functions and adapter rules to make it explicit that the helper
body should be wrapped with the transacting helper and access the client through
the swapped repository handle.
In @.agents/skills/samber-lo/SKILL.md:
- Around line 74-75: The guidance around using lo.Map with lo.Uniq for
slice-wide invariants should also mention that lo.Uniq only works for comparable
projected values. Update the note near the distinct-value validation pattern to
call out this compile-time constraint and point readers to lo.UniqBy when the
projected type may be a slice, map, or otherwise non-comparable, so the
recommendation stays correct and easy to apply.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 082c692c-ddd0-4db9-a9d3-45eee6fa199d
📒 Files selected for processing (3)
.agents/skills/charges/SKILL.md.agents/skills/samber-lo/SKILL.mdAGENTS.md
tothandras
previously approved these changes
Jun 25, 2026
GAlexIHU
previously approved these changes
Jun 25, 2026
borosr
previously approved these changes
Jun 25, 2026
Signed-off-by: Peter Turi <peter.turi@openmeter.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Summary by CodeRabbit
loguidance to prioritize Go standard library collection helpers first, with clearer imports and correctness recommendations.AGENTS.md(maintenance rules, coding conventions structure, generation/dependency notes, and skill compatibility expectations).@query(required imports/using)..coderabbit.yaml, including slimmer guidance around when extra tests are unnecessary.