ci: use Go 1.26 for CodeQL build#4680
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughHey team! Quick one here — the CodeQL Go workflow's "Set up Go" step now pins a fixed Go version (1.26.4) instead of reading it from go.mod, and it broadens the cache dependency path to cover both go.sum and collector/go.sum. ChangesCodeQL Go Workflow Update
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Root Cause
The non-PR CodeQL Go workflow installs Go from the root go.mod, which is currently 1.25.6, then runs
make build GO_BUILD_FLAGS=. That aggregate build includesbuild-benthos-collector, butcollector/go.modrequires Go 1.26.4 and the job runs withGOTOOLCHAIN=local, so the collector build fails before CodeQL analysis.Validation
git diff --checkSummary by CodeRabbit
Greptile Summary
This PR updates the Go CodeQL workflow for the collector build. The main changes are:
actions/setup-goto Go 1.26.4.go.sumfiles to the cache key.Confidence Score: 5/5
This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "ci: use collector Go version for CodeQL ..." | Re-trigger Greptile
Context used (3)