fix(spec): makefile

[tothandras]

Summary by CodeRabbit

• Chores
  • Updated API specification generation to apply consistent operation naming for product catalog addon endpoints.

Greptile Summary

This PR makes the API spec generation Makefile more portable.

• Replaces bash-only string substitution in api/spec/Makefile.
• Uses printf and sed to rewrite addon operation IDs.
• Keeps the same first-match replacement behavior for the listed operations.

Confidence Score: 5/5

This looks safe to merge.

• No blocking issues found in the changed code.
• The new substitution is portable under the default make shell.
• The operation ID rewrite stays equivalent for the current addon operations.

Important Files Changed

Filename	Overview
api/spec/Makefile	Updates the generate target to use a POSIX-compatible operationId substitution.

_{Reviews (1): Last reviewed commit: "fix(spec): makefile" | Re-trigger Greptile}

Context used (3)

• Context used - CLAUDE.md (source)
• Context used - AGENTS.md (source)
• Context used - api/spec/AGENTS.md (source)

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6c1d01c4-c5f9-49bc-bca1-e641fd529dcb

📥 Commits

Reviewing files that changed from the base of the PR and between ef2981c and d021394.

📒 Files selected for processing (1)

• api/spec/Makefile

---

📝 Walkthrough

Walkthrough

The API specification generation target now derives addon operationId names with printf and sed, replacing -addon with -product-catalog-addon before the existing yq update.

Changes

Addon operationId generation

Layer / File(s)	Summary
Update addon operationId replacement api/spec/Makefile	The generate target uses printf and sed to construct renamed addon operationIds while preserving the existing yq update.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

• openmeterio/openmeter#4610: Updates the same addon operationId rewriting logic in api/spec/Makefile.

Suggested reviewers: turip

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title is generic and only names a file area, so it doesn't clearly describe the Makefile operationId rename change.	Rename it to mention the specific change, e.g. "fix(spec): rename addon operationIds in api/spec Makefile".

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/spec-makefile

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}