fix(api): v3 TypeScript sdk datetime validation#4728
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughRFC 3339 wire datetime schemas now accept numeric timezone offsets. Generated template tests and JavaScript client tests verify offset parsing, UTC timestamps, instant conversion, and malformed timestamp rejection. ChangesRFC 3339 Offset Validation
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
turip
approved these changes
Jul 16, 2026
tothandras
disabled auto-merge
July 16, 2026 15:14
tothandras
enabled auto-merge (squash)
July 16, 2026 15:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Bug Fixes
+02:00and-07:00.Znotation and are correctly converted to their corresponding instants.Tests
Greptile Summary
This PR allows RFC 3339 numeric offsets in the TypeScript SDK’s strict datetime validation. The main changes are:
datetime({ offset: true })for wire schemas.Ztimestamps, malformed input, andDateconversion.Confidence Score: 5/5
This looks safe to merge.
Important Files Changed
Dateschema unchanged.dateTimeWirewith the offset-enabled Zod datetime option.Z, malformed values, and instant conversion.Reviews (1): Last reviewed commit: "fix(api): v3 TypeScript sdk datetime val..." | Re-trigger Greptile
Context used (3)