chore: fix critical issue in tar npm package#4766
Conversation
📝 WalkthroughWalkthroughThe pnpm workspace configuration adds dependency versions to maturity-gate exclusions and expands override rules for selected packages and version ranges. ChangesDependency Resolution Policy
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
api/spec/pnpm-workspace.yaml (2)
10-25: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueTidy up the redundant exclusions!
It looks like there are a few older versions of
tar,dompurify,js-yaml, andprotobufjsmixed in here alongside the newer ones. We can safely trim out the older versions to keep the list clean and easy to read.✨ Proposed cleanup
- - esbuild@0.28.1 - - tar@7.5.16 - - dompurify@3.4.9 - - '`@opentelemetry/core`@2.8.0' - - dompurify@3.4.11 - - undici@6.27.0 - - js-yaml@4.1.2 - - protobufjs@7.6.3 - - '`@babel/core`@7.29.1' - - brace-expansion@2.1.2 - - brace-expansion@5.0.7 - - js-yaml@4.3.0 - - tar@7.5.18 - - tar@7.5.19 - - tar@7.5.17 - - protobufjs@7.6.5 + - esbuild@0.28.1 + - '`@opentelemetry/core`@2.8.0' + - dompurify@3.4.11 + - undici@6.27.0 + - js-yaml@4.3.0 + - protobufjs@7.6.5 + - '`@babel/core`@7.29.1' + - brace-expansion@2.1.2 + - brace-expansion@5.0.7 + - tar@7.5.19🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@api/spec/pnpm-workspace.yaml` around lines 10 - 25, Remove the older duplicate exclusions from the workspace exclusions list, retaining only the newest versions for tar, dompurify, js-yaml, and protobufjs. Keep unrelated package exclusions unchanged and preserve the existing YAML list structure.
40-51: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winConsolidate overlapping override ranges.
There are a few overlapping ranges here for
dompurify,js-yaml,protobufjs, and especiallytar. When overrides overlap, it can sometimes make dependency resolution a bit unpredictable.Consolidating them to just cover the widest range pointing to the latest version makes the config much cleaner and ensures pnpm resolves them exactly how we want!
🛠️ Proposed consolidation
- dompurify@<3.4.9: ^3.4.9 - dompurify@<=3.4.10: ^3.4.11 esbuild@>=0.27.3 <0.28.1: ^0.28.1 - js-yaml@>=4.0.0 <4.3.0: ^4.3.0 - js-yaml@>=4.0.0 <=4.1.1: ^4.1.2 - protobufjs@<=7.6.2: ^7.6.3 - protobufjs@>=7.5.0 <=7.6.4: ^7.6.5 + dompurify@<=3.4.10: ^3.4.11 + js-yaml@>=4.0.0 <4.3.0: ^4.3.0 + protobufjs@<=7.6.4: ^7.6.5 'semver@<7.7.4': '>=7.7.4' - tar@<=7.5.15: ^7.5.16 - tar@<=7.5.16: ^7.5.17 - tar@<=7.5.17: ^7.5.18 - tar@<=7.5.18: ^7.5.19 + tar@<=7.5.18: ^7.5.19🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@api/spec/pnpm-workspace.yaml` around lines 40 - 51, Consolidate overlapping pnpm overrides for dompurify, js-yaml, protobufjs, and tar into one entry per package. Use the widest combined matching range for each package and point it to the latest currently specified target: dompurify ^3.4.11, js-yaml ^4.3.0, protobufjs ^7.6.5, and tar ^7.5.19; leave unrelated overrides unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@api/spec/pnpm-workspace.yaml`:
- Around line 10-25: Remove the older duplicate exclusions from the workspace
exclusions list, retaining only the newest versions for tar, dompurify, js-yaml,
and protobufjs. Keep unrelated package exclusions unchanged and preserve the
existing YAML list structure.
- Around line 40-51: Consolidate overlapping pnpm overrides for dompurify,
js-yaml, protobufjs, and tar into one entry per package. Use the widest combined
matching range for each package and point it to the latest currently specified
target: dompurify ^3.4.11, js-yaml ^4.3.0, protobufjs ^7.6.5, and tar ^7.5.19;
leave unrelated overrides unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 48b13281-f6ea-476e-8951-06775d1ae318
⛔ Files ignored due to path filters (1)
api/spec/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
api/spec/pnpm-workspace.yaml
Overview
Fixes #(issue)
Notes for reviewer
Summary by CodeRabbit
Greptile Summary
This PR updates the API specification workspace dependencies to address security advisories. The main changes are:
tarand other affected packages.Confidence Score: 5/5
This looks safe to merge.
Important Files Changed
tarto 7.5.20.Reviews (2): Last reviewed commit: "fix: greptile comment" | Re-trigger Greptile
Context used (3)