Skip to content

Trunk-6636 : Publish Security Events for Security Audit Logging#6094

Open
sudhanshu-raj wants to merge 7 commits into
openmrs:2.7.xfrom
sudhanshu-raj:TRUNK-6636
Open

Trunk-6636 : Publish Security Events for Security Audit Logging#6094
sudhanshu-raj wants to merge 7 commits into
openmrs:2.7.xfrom
sudhanshu-raj:TRUNK-6636

Conversation

@sudhanshu-raj
Copy link
Copy Markdown
Contributor

@sudhanshu-raj sudhanshu-raj commented May 12, 2026

Description of what I changed

Publishing the events like LoginAttemptEvent and LogoutEvent for security audit logging.

Issue I worked on

see https://issues.openmrs.org/browse/TRUNK-6636

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@sudhanshu-raj
Copy link
Copy Markdown
Contributor Author

This is part of openmrs/openmrs-module-auditlogweb#44

@wikumChamith wikumChamith requested review from dkayiwa and ibacher May 16, 2026 10:19
@wikumChamith
Copy link
Copy Markdown
Member

@ibacher @dkayiwa what are your thoughts on this?

@dkayiwa
Copy link
Copy Markdown
Member

dkayiwa commented May 16, 2026

@wikumChamith is there a reason why this is still in draft?

@wikumChamith
Copy link
Copy Markdown
Member

@wikumChamith is there a reason why this is still in draft?

I think @sudhanshu-raj wanted to get feedback on this approach.

@sudhanshu-raj
Copy link
Copy Markdown
Contributor Author

@wikumChamith is there a reason why this is still in draft?

I think @sudhanshu-raj wanted to get feedback on this approach.

Ya, actually I just want to make sure if this approach sounds good then will probably added some test cases then.

@sudhanshu-raj
Copy link
Copy Markdown
Contributor Author

I reduced the changes to use only for publishing the login attempt event bcz account locked event is not there on existing listener.

@sonarqubecloud
Copy link
Copy Markdown

@sudhanshu-raj
Copy link
Copy Markdown
Contributor Author

This is now ready for review.

@sudhanshu-raj sudhanshu-raj marked this pull request as ready for review May 29, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants