TRUNK-6646: Env-var key normalization drops create_database_* / create_user_* credentials in scripted setup#6145
Open
jwnasambu wants to merge 2 commits into
Open
TRUNK-6646: Env-var key normalization drops create_database_* / create_user_* credentials in scripted setup#6145jwnasambu wants to merge 2 commits into
jwnasambu wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6145 +/- ##
============================================
- Coverage 59.05% 59.04% -0.01%
+ Complexity 9243 9242 -1
============================================
Files 693 693
Lines 37257 37257
Branches 5485 5485
============================================
- Hits 22003 22000 -3
- Misses 13284 13287 +3
Partials 1970 1970 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jwnasambu
force-pushed
the
TRUNK-6646
branch
2 times, most recently
from
8c44666 to
2675546
Compare
…e_user_* credentials in scripted setup
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
I expanded NON_NORMALIZED_KEYS: By adding the following keys to the allow list to prevent incorrect normalization (preserving underscores):
* CONNECTION_DRIVER_CLASS
* CREATE_DATABASE_USERNAME
* CREATE_DATABASE_PASSWORD
* CREATE_USER_USERNAME
* CREATE_USER_PASSWORD
Also I updated the initializeWizardFromResolvedPropertiesIfPresent method to resolve the database driver from both connection.driver_class (dot notation) and connection_driver_class (underscore notation). This ensures compatibility regardless of whether the value comes from a runtime properties file or a normalized environment variable.
Issue I worked on
https://openmrs.atlassian.net/issues?filter=10641&selectedIssue=TRUNK-6646
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master