O3-5649: Use GitHub Artifacts for spa-assemble-config.json#1010
O3-5649: Use GitHub Artifacts for spa-assemble-config.json#1010Bawanthathilan wants to merge 3 commits into
Conversation
| - name: Extract spa-assemble-config.json | ||
| run: | | ||
| IMAGE="${{ env.IMAGE }}:${{ env.DOCKER_IMAGE_TAG }}" | ||
| docker pull $IMAGE |
There was a problem hiding this comment.
I was reviewing this pipeline and had a quick question about this step. Since we just built the Docker image in the same job, could we skip the docker pull and just directly docker create the container from the local cache?
I'm guessing we have to pull it because the docker/build-push-action is performing a multi-platform build, which pushes the image directly to the registry and prevents it from loading into the runner's docker daemon? Just wanted to confirm if that was the case.
There was a problem hiding this comment.
Yeah, no need to pull. We should use the image built by the job.
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: spa-assemble-config | ||
| path: ./spa-assemble-config.json |
There was a problem hiding this comment.
Since the spa-assemble-config.json file is only needed for the next job, it only needs to be stored temporarily. We can limit it using retention-days: 1. Is this is a valid approach?
There was a problem hiding this comment.
yes, 1 day would be more than enough.
jayasanka-sack
changed the title
Co-authored-by: Copilot <copilot@github.com>
4 participants
Summary
Update workflow to use GitHub Artifacts for spa-assemble-config.json instead of re-downloading the Docker image.
Changes
openmrs.atlassian.net/browse/O3-5649