fix(admin-tools): add noopener to new-tab card links#268
Open
praneeth622 wants to merge 1 commit into
Open
Conversation
Replaces the misspelled rel="norefferer" on the dashboard LinkCard with rel="noopener noreferrer". Without noopener, target="_blank" exposes the opened page's window.opener to the parent (tabnabbing), and the typo meant the browser never recognised the noreferrer hint either.
There was a problem hiding this comment.
Pull request overview
This PR fixes a security-related typo in the system admin dashboard LinkCard anchor attributes to prevent reverse tabnabbing when opening links in a new tab.
Changes:
- Replaces
rel="norefferer"(typo) withrel="noopener noreferrer"on theLinkCardanchor that usestarget="_blank".
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
The dashboard
LinkCardopens itsviewLinkin a new tab (target="_blank") but setsrel="norefferer"— a typo ofnoreferrerthat browsers silently ignore, andnoopenerisn't present at all. That leaves the opened page able to reachwindow.opener(classic tabnabbing). Replaced the rel value withrel="noopener noreferrer".The same copy-pasted typo also appears in
packages/esm-admin-openconceptlab-app/src/admin-ocl-card-link.component.tsx:11and can be fixed in a follow-up PR.Screenshots
N/A — the change is a single HTML attribute on an anchor; no visual diff.
Related Issue
None filed; spotted during a casual review.
Other
Verified with
yarn turbo typescript testlocally: all 6 tasks (3 typescript + 3 test) succeed.