HTML-760: adding a new relationship to save to the submission actions#280
Open
jona42-ui wants to merge 1 commit into
Open
HTML-760: adding a new relationship to save to the submission actions#280jona42-ui wants to merge 1 commit into
jona42-ui wants to merge 1 commit into
Conversation
… that are processed together in a single transaction upon form submission
Contributor
Author
|
this is provisional to give an example |
|
One suggestion: Since this introduces a new SaveRelationshipAction, it might be helpful to add tests or validation to ensure relationships correctly persisted within the submission transaction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Used the RelationshipService to add a new relationship to a form submission in the handleSubmission method of a SubmissionElement. The handleSubmission method creates a new relationship using the RelationshipService, then adds it to the submission actions by creating a new SaveRelationshipAction and passing the relationship as a parameter
Issue I worked on
see https://issues.openmrs.org/projects/HTML/issues/HTML-760?filter=allopenissues
Checklist: I completed these to help reviewers :)
My pull request only contains ONE single commit
(the number above, next to the 'Commits' tab is 1).
My IDE is configured to follow the code style of this project.
My pull request is based on the latest changes of the master branch.