HTML-760: Fix relationship tag transaction bug#329
Open
arti-nova wants to merge 1 commit into
Open
Conversation
krisha-9
reviewed
Mar 26, 2026
krisha-9
left a comment
There was a problem hiding this comment.
The change from directly saving the relationship to queuing it via submissionActions looks good and aligns better with the form submission workflow.
One suggestion: consider adding validation or checks to ensure that the relationship object is not null and avoids unintended duplicates before adding it to the queue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTML-760: Fix relationship tag transaction bug
JIRA: https://openmrs.atlassian.net/browse/HTML-760
Summary:
This PR fixes the relationship tag transaction bug where relationships were being persisted outside the form submission transaction. Previously, relationships created using the relationship tag were saved immediately, resulting in separate synchronization records.
Now:
Relationship creation is queued in submission actions and processed within the same transaction as form submission, ensuring transactional consistency.
Changes:
Testing:
Notes: