Conversation
mseaton
reviewed
Jun 23, 2026
| private static final String ATTRIBUTE_SPECIALITIES = "specialities"; | ||
| private static final String ATTRIBUTE_SORT_BY = "sortBy"; | ||
|
|
||
| private static final String ATTRIBUTE_SORT_BY_SPECIALITIES_ORDER_THEN_SERVICE_NAME = "specialitiesOrderThenServiceName"; |
Member
There was a problem hiding this comment.
Not in love with this attribute name. Can we change this so that sortBy can take a comma-delimited list of options, so the default would be "sortBy=serviceName", but in our forms it would be "sortBy=specialty,serviceName"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…erviceObs tag
This PR adds an optional
sortByattribute to the<apointmentServiceObs>tag. When specified with the valuespecialitiesOrderThenServiceName, it sorts the appointment service options first by the order of the specialities in thespecialitiesattribute, then by service name. This allows us to make the "Other" service option appear at the end of the dropdown list.See: PIH/openmrs-config-pihsl#324 for usage