Skip to content

META-377:Fix: Generalized PersistentCollection conversion #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChathuniSoori wants to merge 1 commit into
base: master
Choose a base branch
from
Open

META-377:Fix: Generalized PersistentCollection conversion #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions ...nmrs/module/metadatasharing/serializer/converter/CollectionConverterCompatibility2_0.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,21 +46,14 @@ public boolean canConvert(Class type) {

@Override
public void marshal(Object source, HierarchicalStreamWriter writer,
MarshallingContext context, ConverterLookup converterLookup) {

if (source instanceof PersistentList) {
source = new ArrayList((Collection) source);
} else if (source instanceof PersistentMap) {
source = new HashMap((Map) source);
} else if (source instanceof PersistentSortedMap) {
source = new TreeMap((SortedMap) source);
} else if (source instanceof PersistentSortedSet) {
source = new TreeSet((SortedSet) source);
} else if (source instanceof PersistentSet) {
source = new HashSet((Set) source);
MarshallingContext context, ConverterLookup converterLookup) {

if (source instanceof PersistentCollection) {
source = new ArrayList<>((Collection<?>) source);
}
// delegate the collection to the appropriate converter

// Delegate to the appropriate converter
converterLookup.lookupConverterForType(source.getClass()).marshal(source, writer, context);
}

}