RA-1988 - Allow DatetimePicker to support different timezones

[icrc-toliveira]

Issue: https://issues.openmrs.org/browse/RA-1988

Description:
When using a date time picker (with time), it will not store the date with time-zone information.
This will result in date being stored always as if was UTC, even when is not.

Changes done:

• Change initial date string format from "dd MMM yyyy HH:mm" to "dd MMM yyyy HH:mm:ss" (now show's seconds, to be in order with the remaining formats)
• Change date Picker format from "dd M yyyy HH:mm" to "dd M yyyy hh:ii:ss" (this is time used after picking with the date time picker)
• Updating format every time a change happens (this is required in order to send time zone)

Related PR's:

• HTML-1988 - Setting the timezone were instead of having it already as… openmrs-module-htmlformentryui#58
• RA-1988 - When seething dates to midnight, change the required Global property from allowChangingVisitTime to allowConvertingTimezones openmrs-module-coreapps#457

[icrc-toliveira]

Hi @dkayiwa,
Could you take a look at this

[sherrif10]

@icrc-toliveira Thanks for working on this, Do you mind sharing the screenshot .

[icrc-toliveira]

Hi @sherrif10

Sorry for my late response,
In the past month I did take a deeper look into this and found many issues.

When developed, datetimepicker didn´t seem to take time zones into account, and in order for this to work a lot of stuff had to be changed.

• This PR, start with a refactor of the code, to make it easier to read. (use of ternary operators instead of relaying of multiple if's)
• After that I added a new shortDateStringFormat to handle some of the start / end dates that were causing troubles (occurring when the start / end given were dates without time)
• Other issue was the inability for the datetimepicker to handle different languages, the format used was not working for French language and completely breaking if a prior date was saved in English and the edited in French. (datePickerFormat as 'dd M yyyy hh:ii:ss', seems to work for every language)
• Dates can now be saved in both "YYYY-MM-DD HH:mm:ss" (when no time / timezone is needed) and "YYYY-MM-DDTHH:mm:ss.sssZ". The use of both format, is done in order to keep compatibility with older versions, since there is no good way of having this work for both (htmlformentryui) encounters and the edit visit page.
• Sometimes date would only save in a 12 hour format instead of 24

Example of 12h format bug:

[gracepotma]

@dkayiwa could you kindly review this for merging? Apparently it's one of several blockers for ICRC.

[dkayiwa]

@icrc-toliveira remember to always hit the Request Code Review button on the JIRA ticket, whenever you are ready for review.