feat: use remote dev for r2 cache population#1159
Conversation
🦋 Changeset detectedLatest commit: fbdae21 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
f037821 to
b1085e0
Compare
|
Hi @edmundhung, I've decided to give it a go and unfortunately current state of PR does not resolve #1110 Some additional progress and: Or Some additional progress and: Tested on Next.js 15.5.14 and 16.1.6. |
Use Wrangler remote dev for remote R2 cache population, ensure the target bucket exists before uploading cache entries, and isolate the helper worker from project config discovery. Co-authored-by: Victor Berchet <victor@suumit.com> Co-authored-by: Isaac Rowntree <isaac@rowntree.me>
b1085e0 to
92b3cf2
Compare
|
@grabmateusz Thanks for giving this a try 🙏🏼 I have made a few additional changes to make the remote cache populate path more resilient. Would you mind giving the pre-release another try? npm i https://pkg.pr.new/@opennextjs/cloudflare@92b3cf2If it still fails, could you also try lowering |
|
Hi @edmundhung, this looks much better, I've run 6 parallel deployments (without adjusting or Test performed so far only on Next.js 15.5.14 but looks promising, will update this comment tomorrow with Next.js 16.1.6 test results. |
petebacondarwin
left a comment
There was a problem hiding this comment.
A bunch of comments. Hope they are helpful.
petebacondarwin
left a comment
There was a problem hiding this comment.
Thanks for addressing all my feedback
|
Thanks for the review, @petebacondarwin and @james-elicx! |
|
@grabmateusz We are ready to ship this. If you get a chance, feel free to give the latest build another try. |
|
Hi @edmundhung, newest package tested o both Next.js 15.5.14 and 16.1.6. |
|
Thanks for all the feedbacks, @grabmateusz. This is released in v1.18.0. |
Fixes #1110, #1088
Close #1121, #1099
This is based on the work @vicb and @isaacrowntree did in the PRs above, with the following changes:
config: ""when starting the helper worker to avoid auto-discovering the project wrangler config and leaking unrelated bindings into the cache-populate worker