fix: drop streaming wasm calls in Turbopack runtime#1244
Open
tahmid-23 wants to merge 2 commits intoopennextjs:mainfrom
Open
fix: drop streaming wasm calls in Turbopack runtime#1244tahmid-23 wants to merge 2 commits intoopennextjs:mainfrom
tahmid-23 wants to merge 2 commits intoopennextjs:mainfrom
Conversation
Turbopack replaces wasm imports using `WebAssembly.compileStreaming` and `WebAssembly.instantiateStreaming`. These functions are not available in the workerd runtime. We add a helper `loadWasmChunkFn`. This is a generated switch statement that contains an import for each wasm chunk. We use static strings for all imports to ensure that all necessary wasm chunks will be detected and bundled for the final build. The Turbopack patcher replaces the invocations in `loadWebAssembly` and `loadWebAssemblyModule`, using the synchronous `WebAssembly.instantiate` and redirecting to `loadWasmChunkFn`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 31b50a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
commit: |
Contributor
|
Thanks for the PR!
Could you please add an e2e test for that? |
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Author
|
cc @vicb done (relying on ai having set up the test itself correctly but it seems to pass with the change and fail without) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turbopack replaces wasm imports using
WebAssembly.compileStreamingandWebAssembly.instantiateStreaming. These functions are not available in the workerd runtime.We add a helper
loadWasmChunkFn. This is a generated switch statement that contains an import for each wasm chunk. We use static strings for all imports to ensure that all necessary wasm chunks will be detected and bundled for the final build.The Turbopack patcher replaces the invocations in
loadWebAssemblyandloadWebAssemblyModule, using the synchronousWebAssembly.instantiateand redirecting toloadWasmChunkFn.This fixes #1191, since Prisma 7 uses wasm.
I verified by applying (a slightly simplified version of) this patch to fix the error for myself. I also asked claude to verify that
WebAssembly.compileStreaming/WebAssembly.instantiateStreamingwere replaced in the final output, and that the switch case is generated.