fix: do not log expected expected D1 errors#1246
Conversation
🦋 Changeset detectedLatest commit: a6da948 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
sommeeeer
left a comment
There was a problem hiding this comment.
LGTM, would it make sense to use NOT EXISTS instead?
Unfortunately, it is not supported for |
|
Thanks for the review Magnus! |
Co-authored-by: Victor Berchet <victor@suumit.com>
james-elicx
left a comment
There was a problem hiding this comment.
We could probably do a query that checks if they exist already, but any real errors would likely already be flagged by this point i imagine
I thought about that first but I don't think it would be better than the simple solution implemented in this PR. WDYT? Thanks James |
Yeah i would probably agree |
A user reported this error on Discord:
As explained in the changelog, the error is expected when the column exists.