Skip to content

refactor: only test prisma v7 with turbopack#1247

Merged
vicb merged 2 commits intomainfrom
vicb/turbopack
May 4, 2026
Merged

refactor: only test prisma v7 with turbopack#1247
vicb merged 2 commits intomainfrom
vicb/turbopack

Conversation

@vicb
Copy link
Copy Markdown
Contributor

@vicb vicb commented May 4, 2026

The supposedly webpack e2e is actually also testing turbopack (it is the default when using next build without further option in Next 16).

This PR:

  • makes it explicit that we use turbopack by using next build --turbopack (unchanged behavior)
  • remove the "webpack" test that was actually testing turbopack
  • cleanup unneeded files

/cc @tahmid-23


Open in Devin Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 4, 2026

⚠️ No Changeset found

Latest commit: 6f98ad6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 4, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@opennextjs/cloudflare@1247

commit: 6f98ad6

devin-ai-integration[bot]

This comment was marked as resolved.

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 2 additional findings in Devin Review.

Open in Devin Review

Comment thread examples/prisma-7/package.json
Copy link
Copy Markdown
Collaborator

@sommeeeer sommeeeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, in the PR description you say webpack but I think you meant turbopack

@vicb
Copy link
Copy Markdown
Contributor Author

vicb commented May 4, 2026

LGTM, in the PR description you say webpack but I think you meant turbopack

Thanks for the review & good catch!

@vicb vicb merged commit 13c3e75 into main May 4, 2026
8 checks passed
@vicb vicb deleted the vicb/turbopack branch May 4, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants