fix: normalize Windows paths in copyWorkerdPackages so serverExternalPackages match#1268
Open
ton11797 wants to merge 1 commit into
Open
fix: normalize Windows paths in copyWorkerdPackages so serverExternalPackages match#1268ton11797 wants to merge 1 commit into
ton11797 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: eb874f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem #661
On Windows, packages listed in serverExternalPackages were silently dropped from the workerd-condition copy step, leaving their web.mjs / web.cjs files absent from
the bundle. The downstream esbuild then fails with Could not resolve "" and a message that ./web.mjs was not found.
Concrete repro: a Next.js app on Windows using @libsql/client with serverExternalPackages: ["@libsql/isomorphic-ws"] will fail opennextjs-cloudflare build because @libsql/isomorphic-ws declares "workerd": "./web.mjs" in its exports but only node.cjs/node.mjs/package.json get copied.
Cause
copyWorkerdPackages extracted the package name with src.match(/./node_modules/(?.)/) (cross-platform via getCrossPlatformPathRegex). The regex matched, but the captured pkg group retained the path's native separator. On Windows the captured value was @libsql\isomorphic-ws, which never matched the forward-slash entry in serverExternalPackages, so the workerd-copy was skipped.
Fix
Extracted a small helper that:
Tests
Added unit tests for the helper covering POSIX/Windows × scoped/unscoped/subpath, plus a non-node_modules negative case.