feat: Enhance compactor resource configuration#190
Conversation
This update adds resource requests and limits for the volume-permissions init container and the check-etcd and check-nats init containers in the compactor deployment. This ensures better resource management and performance for the compactor component.
|
@mmosarafO2 can you please also review this PR ? |
|
i don't think check-nats pod itself will OOM, please help check the OOM pod is initContainer or compactor container. |
|
I checked this again. The intent of the PR is not specifically to fix an observed OOMKilled Since init container resources also contribute to the pod’s effective resource profile, this PR moves the compactor init container resources into values so they can be configured by chart users. |
|
Make sense, but i don't think it is necessary. Because the initContainer do nothing. only used to check if nats startted. |
Until now, there is only a single resource definition for the compactor pod assigning the values to all containers in the deployment. The limits for the
check-natscontainer are hard-coded in the template:This prevents the allocation of resources beyond these limits for the main container of the compactor service, too. As a result of the low resource allocation, the compactor service gets
OOMKilledfrequently during regular operations.This update adds separate resource requests and limits for the init containers and the main container in the compactor deployment to ensure better resource management and performance for the compactor component.