Interest in more historic data?

[HolgerJeromin]

We have an opening-hours project for Openstreetmap data.
For that our community collected holiday data.

We are now trying to convert to use openholidaysapi data. Thanks for them!
opening-hours/opening_hours.js#544

But this would result in loosing some historic data for some countries.
For example for Germany we have data since 2012.

Are you interested in importing them/having them in your repo?
Otherwise we have to delete them (unsure if this is a problem for someone) or keep a second datasource.

[fstueber]

Great. I am open for importing/merging those data.

[fstueber]

I think I found it: https://github.com/opening-hours/opening_hours.js/blob/develop/src/holidays/de.yaml

Any way to provide this in a more "friendly" semantic?

[KristjanESPERANTO]

It would be really great if we could bring that together! I'm working on a PR 🙂

[fstueber]

Merged. Please check.

[HolgerJeromin]

#154 pending :)

[KristjanESPERANTO]

Since #154 is merged, I think we can close this issue. That's a fantastic milestone 😃

[HolgerJeromin]

@KristjanESPERANTO Do you want to update the readme, too?
https://github.com/openpotato/openholidaysapi.data/blob/develop/README.md
The data range (since 2020) is not valid anymore.
I can create a PR, too, but this is your merit

[KristjanESPERANTO]

@HolgerJeromin Good point. I wouldn't be mad if you create a PR 🙂

[fstueber]

Yes, and indicate your authorship if you want.

[HolgerJeromin]

opened #158
.oO( I like git foo: KristjanESPERANTO authored and HolgerJeromin committed ) :-)

[KristjanESPERANTO]

Thank you both! With the latest PRs merged, we can now proceed with our migration 🥳