Skip to content

bugfix: remove sslhandshake result assert for pre-handshake errors. #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhuizhuhaomeng merged 1 commit into from
Jun 6, 2026
+3 −5
Merged

bugfix: remove sslhandshake result assert for pre-handshake errors. #534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions lib/resty/core/socket.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,14 +424,10 @@ local function sslhandshake(cosocket, reused_session, server_name, ssl_verify,
error("no request ctx found", 2)
end

local res

if rc == FFI_ERROR then
res = C.ngx_http_lua_ffi_socket_tcp_get_sslhandshake_result(r, u,
C.ngx_http_lua_ffi_socket_tcp_get_sslhandshake_result(r, u,
session_ptr, errmsg, openssl_error_code)

assert(res == FFI_ERROR)

if openssl_error_code[0] ~= 0 then
return nil, openssl_error_code[0] .. ": " .. ffi_str(errmsg[0])
end
Expand All @@ -443,6 +439,8 @@ local function sslhandshake(cosocket, reused_session, server_name, ssl_verify,
return reused_session
end

local res

if rc == FFI_OK then
if reused_session == false then
return true
Expand Down
Loading