feature: clienthello.set_ciphers().#535
Open
climagabriel wants to merge 1 commit into
Open
Conversation
Sets the connection's TLS <= 1.2 cipher list and/or TLS 1.3 ciphersuites from ssl_client_hello_by_lua*, e.g. keyed on the client hello server name. On failure the connection's SSL object is left exactly as it was -- cipher list, ciphersuites, and error queue all untouched -- so the handshake proceeds with the default list inherited from the server block (ssl_ciphers/ssl_conf_command). Requires ngx_http_lua_ffi_ssl_set_ciphers() from lua-nginx-module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
clienthello.set_ciphers(ciphers, ciphersuites?)to set the connection's TLS <= 1.2 cipher list and/or TLS 1.3 ciphersuites fromssl_client_hello_by_lua*, e.g. keyed on the client hello server name. Complementsclienthello.set_protocols().On failure the connection's SSL object is left exactly as it was -- cipher list, ciphersuites, and error queue all untouched -- so the handshake proceeds with the default list inherited from the server block (
ssl_ciphers/ssl_conf_command). See openresty/lua-nginx-module#2513 for why that guarantee needs pre-validation on a scratchSSL_CTX.Requires
ngx_http_lua_ffi_ssl_set_ciphers()from openresty/lua-nginx-module#2513.Tests: valid list applied (negotiated cipher asserted), invalid TLS <= 1.2 list fails without breaking the handshake, invalid TLS 1.3 ciphersuites fail without breaking the handshake.