AssertJ best practices

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.testing.assertj.Assertj?organizationId=ODQ2MGExMTUtNDg0My00N2EwLTgzMGMtNGE1NGExMTBmZDkw

Co-authored-by: Moderne <team@moderne.io>

Author: timtebeek

src/test/java/org/openrewrite/java/dependencies/DependencyResolutionDiagnosticTest.java

@@ -68,8 +68,9 @@ void gradle() {
             // It is a limitation of the tooling API which prevents configuration-granularity error information from being collected.
             // So the GradleDependencyConfigurationErrors table will never be populated in unit tests.
             .dataTable(RepositoryAccessibilityReport.Row.class, rows -> {
-                assertThat(rows).hasSize(4);
-                assertThat(rows).contains(
+                assertThat(rows)
+                        .hasSize(4)
+                        .contains(
                   new RepositoryAccessibilityReport.Row("https://repo.maven.apache.org/maven2", "", "", 200, "", ""));
                 assertThat(rows).filteredOn(row -> row.getUri().startsWith("file:/") && "".equals(row.getPingExceptionMessage())).hasSize(1);
                 assertThat(rows).contains(
@@ -107,10 +108,11 @@ void gradleNoDefaultRepos() {
             // It is a limitation of the tooling API which prevents configuration-granularity error information from being collected.
             // So the GradleDependencyConfigurationErrors table will never be populated in unit tests.
             .dataTable(RepositoryAccessibilityReport.Row.class, rows -> {
-                assertThat(rows).hasSize(2);
-                assertThat(rows).contains(
-                  new RepositoryAccessibilityReport.Row("https://plugins.gradle.org/m2", "", "", 200, "", ""));
-                assertThat(rows).contains(
+                assertThat(rows)
+                        .hasSize(2)
+                        .contains(
+                  new RepositoryAccessibilityReport.Row("https://plugins.gradle.org/m2", "", "", 200, "", ""))
+                        .contains(
                   new RepositoryAccessibilityReport.Row("https://nonexistent.moderne.io/maven2", "java.net.UnknownHostException", "nonexistent.moderne.io", null, "", ""));
             }),
           //language=groovy
@@ -157,10 +159,11 @@ void mavenSettingsWithMirrors() {
               ctx.setMavenSettings(settings);
               spec.beforeRecipe(withToolingApi())
                 .dataTable(RepositoryAccessibilityReport.Row.class, rows -> {
-                    assertThat(rows).contains(
+                    assertThat(rows)
+                            .contains(
                       new RepositoryAccessibilityReport.Row("https://nonexistent.moderne.io/maven2", "java.net.UnknownHostException", "nonexistent.moderne.io", null, "", "")
-                    );
-                    assertThat(rows).noneMatch(repo -> repo.getUri().contains("https://repo.maven.apache.org/maven2"));
+                    )
+                            .noneMatch(repo -> repo.getUri().contains("https://repo.maven.apache.org/maven2"));
                 })
                 .executionContext(ctx);
           },

src/test/java/org/openrewrite/java/dependencies/internal/StaticVersionComparatorTest.java

@@ -26,10 +26,10 @@ class StaticVersionComparatorTest {
 
     @Test
     void milestone() {
-        assertThat(svc.compare(v("2.0.0"), v("1.0.0"))).isEqualTo(1);
-        assertThat(svc.compare(v("1.0.0"), v("1.0.0-M1"))).isEqualTo(1);
-        assertThat(svc.compare(v("1.0.0-M2"), v("1.0.0-M1"))).isEqualTo(1);
-        assertThat(svc.compare(v("1.0.0-rc-1"), v("1.0.0-M1"))).isEqualTo(1);
+        assertThat(svc.compare(v("2.0.0"), v("1.0.0"))).isOne();
+        assertThat(svc.compare(v("1.0.0"), v("1.0.0-M1"))).isOne();
+        assertThat(svc.compare(v("1.0.0-M2"), v("1.0.0-M1"))).isOne();
+        assertThat(svc.compare(v("1.0.0-rc-1"), v("1.0.0-M1"))).isOne();
     }
 
     Version v(String version) {