Create a Guava recipe to inline methods and move the tests there

Author: timtebeek

src/main/resources/META-INF/rewrite/no-guava.yml

@@ -29,6 +29,7 @@ recipeList:
   - org.openrewrite.java.migrate.guava.NoGuavaJava21
   - org.openrewrite.java.migrate.guava.NoGuavaCreateTempDir
   - org.openrewrite.java.migrate.guava.NoGuavaDirectExecutor
+  - org.openrewrite.java.migrate.guava.NoGuavaInlineMeMethods
   - org.openrewrite.java.migrate.guava.NoGuavaListsNewArrayList
   - org.openrewrite.java.migrate.guava.NoGuavaListsNewCopyOnWriteArrayList
   - org.openrewrite.java.migrate.guava.NoGuavaListsNewLinkedList
@@ -108,6 +109,20 @@ recipeList:
   - org.openrewrite.java.migrate.guava.NoMapsAndSetsWithExpectedSize
   - org.openrewrite.java.migrate.guava.PreferMathClamp
 
+---
+type: specs.openrewrite.org/v1beta/recipe
+name: org.openrewrite.java.migrate.guava.NoGuavaInlineMeMethods
+displayName: Inline Guava method calls
+description: >-
+  Inline Guava method calls that are annotated with `@InlineMe` to their replacement method.
+tags:
+  - guava
+preconditions:
+  - org.openrewrite.analysis.search.FindMethods:
+      methodPattern: com.google.common..* *(..)
+recipeList:
+  - org.openrewrite.java.migrate.InlineMethodCalls
+
 ---
 type: specs.openrewrite.org/v1beta/recipe
 name: org.openrewrite.java.migrate.guava.PreferJavaNioCharsetStandardCharsets

src/test/java/org/openrewrite/java/migrate/InlineMethodCallsTest.java

@@ -15,19 +15,12 @@
  */
 package org.openrewrite.java.migrate;
 
-import org.junit.jupiter.api.Nested;
 import org.junit.jupiter.api.Test;
 import org.openrewrite.DocumentExample;
-import org.openrewrite.Recipe;
 import org.openrewrite.java.JavaParser;
-import org.openrewrite.java.tree.J;
-import org.openrewrite.java.tree.JavaSourceFile;
 import org.openrewrite.test.RecipeSpec;
 import org.openrewrite.test.RewriteTest;
 
-import java.util.List;
-
-import static org.assertj.core.api.Assertions.assertThat;
 import static org.openrewrite.java.Assertions.java;
 
 class InlineMethodCallsTest implements RewriteTest {
@@ -444,77 +437,4 @@ void foo(Builder builder) {
           )
         );
     }
-
-    @Nested
-    class Guava {
-        @Test
-        void stringsRegular() {
-            rewriteRun(
-              java(
-                """
-                  import com.google.common.base.Strings;
-                  class Regular {
-                      String repeatString(String s, int n) {
-                          return Strings.repeat(s, n);
-                      }
-                  }
-                  """,
-                """
-                  class Regular {
-                      String repeatString(String s, int n) {
-                          return s.repeat(n);
-                      }
-                  }
-                  """
-              )
-            );
-        }
-
-        @Test
-        void stringsStaticImport() {
-            rewriteRun(
-              java(
-                """
-                  import static com.google.common.base.Strings.repeat;
-                  class StaticImport {
-                      String repeatString(String s, int n) {
-                          return repeat(s, n);
-                      }
-                  }
-                  """,
-                """
-                  class StaticImport {
-                      String repeatString(String s, int n) {
-                          return s.repeat(n);
-                      }
-                  }
-                  """
-              )
-            );
-        }
-
-        @Test
-        void methodTypeParameterNames() {
-            rewriteRun(
-              spec -> spec.beforeRecipe(list -> {
-                    JavaSourceFile first = (JavaSourceFile) list.getFirst();
-                    J.MethodDeclaration foo = (J.MethodDeclaration) first.getClasses().getFirst().getBody().getStatements().getFirst();
-                    J.MethodInvocation repeat = (J.MethodInvocation) foo.getBody().getStatements().getFirst();
-                    List<String> parameterNames = repeat.getMethodType().getParameterNames();
-                    assertThat(parameterNames).containsExactly("string", "count");
-                })
-                .recipe(Recipe.noop()),
-              java(
-                """
-                  import com.google.common.base.Strings;
-                  class Foo {
-                      void foo(String s, int n) {
-                          Strings.repeat(s, n);
-                      }
-                  }
-                  """
-              )
-            );
-        }
-    }
 }

src/test/java/org/openrewrite/java/migrate/guava/NoGuavaInlineMeMethods.java

@@ -0,0 +1,80 @@
+/*
+ * Copyright 2025 the original author or authors.
+ * <p>
+ * Licensed under the Moderne Source Available License (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * <p>
+ * https://docs.moderne.io/licensing/moderne-source-available-license
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.openrewrite.java.migrate.guava;
+
+import org.junit.jupiter.api.Test;
+import org.openrewrite.DocumentExample;
+import org.openrewrite.test.RecipeSpec;
+import org.openrewrite.test.RewriteTest;
+
+import static org.openrewrite.java.Assertions.java;
+
+class NoGuavaInlineMeMethods implements RewriteTest {
+
+    @Override
+    public void defaults(RecipeSpec spec) {
+        spec.recipeFromResource(
+          "/META-INF/rewrite/no-guava.yml",
+          "org.openrewrite.java.migrate.guava.NoGuavaInlineMeMethods");
+    }
+
+    @DocumentExample
+    @Test
+    void stringsRegular() {
+        rewriteRun(
+          java(
+            """
+              import com.google.common.base.Strings;
+              class Regular {
+                  String repeatString(String s, int n) {
+                      return Strings.repeat(s, n);
+                  }
+              }
+              """,
+            """
+              class Regular {
+                  String repeatString(String s, int n) {
+                      return s.repeat(n);
+                  }
+              }
+              """
+          )
+        );
+    }
+
+    @Test
+    void stringsStaticImport() {
+        rewriteRun(
+          java(
+            """
+              import static com.google.common.base.Strings.repeat;
+              class StaticImport {
+                  String repeatString(String s, int n) {
+                      return repeat(s, n);
+                  }
+              }
+              """,
+            """
+              class StaticImport {
+                  String repeatString(String s, int n) {
+                      return s.repeat(n);
+                  }
+              }
+              """
+          )
+        );
+    }
+}