Cap Java version at 24 for Kotlin <2.3 in UpgradeToJava25 (#1035)

* Cap Java version at 24 for Kotlin <2.3 in UpgradeToJava25 (#2126)

Kotlin versions before 2.3 only support up to Java 24. When running
UpgradeToJava25 on projects with kotlin-stdlib <2.3, the Java version
is now set to 24 instead of 25.

* Use ModuleHasDependency invertMarking instead of custom ScanningRecipe

Replace HasNoOldKotlinDependency with ModuleHasDependency's invertMarking
option for detecting projects without Kotlin <2.3.

* Inline Kotlin version check recipes into UpgradeToJava25

Remove the intermediate UpgradeBuildToJava25 wrapper and reference
UpgradeBuildToJava24ForOldKotlin and UpgradeBuildToJava25Default
directly from UpgradeToJava25.

* Rename UpgradeBuildToJava25Default to UpgradeBuildToJava25

* Rename UpgradeBuildToJava24ForOldKotlin to UpgradeBuildToJava24

Author: timtebeek

src/main/resources/META-INF/rewrite/java-version-25.yml

@@ -28,8 +28,8 @@ preconditions:
   - org.openrewrite.Singleton
 recipeList:
   - org.openrewrite.java.migrate.UpgradeToJava21
-  - org.openrewrite.java.migrate.UpgradeJavaVersion:
-      version: 25
+  - org.openrewrite.java.migrate.UpgradeBuildToJava24
+  - org.openrewrite.java.migrate.UpgradeBuildToJava25
   - org.openrewrite.java.migrate.UpgradePluginsForJava25
   - org.openrewrite.java.migrate.io.ReplaceSystemOutWithIOPrint
   - org.openrewrite.java.migrate.lang.MigrateMainMethodToInstanceMain
@@ -217,3 +217,34 @@ recipeList:
       groupId: net.bytebuddy
       artifactId: byte-buddy*
       newVersion: 1.17.x
+
+---
+type: specs.openrewrite.org/v1beta/recipe
+name: org.openrewrite.java.migrate.UpgradeBuildToJava24
+displayName: Upgrade build to Java 24 for Kotlin <2.3
+description: >-
+  Kotlin versions before 2.3 only support up to Java 24.
+preconditions:
+  - org.openrewrite.java.dependencies.search.ModuleHasDependency:
+      groupIdPattern: org.jetbrains.kotlin
+      artifactIdPattern: kotlin-stdlib*
+      version: "[0,2.3)"
+recipeList:
+  - org.openrewrite.java.migrate.UpgradeJavaVersion:
+      version: 24
+
+---
+type: specs.openrewrite.org/v1beta/recipe
+name: org.openrewrite.java.migrate.UpgradeBuildToJava25
+displayName: Upgrade build to Java 25 (default)
+description: >-
+  Upgrades build files to Java 25 for projects without Kotlin <2.3.
+preconditions:
+  - org.openrewrite.java.dependencies.search.ModuleHasDependency:
+      groupIdPattern: org.jetbrains.kotlin
+      artifactIdPattern: kotlin-stdlib*
+      version: "[0,2.3)"
+      invertMarking: true
+recipeList:
+  - org.openrewrite.java.migrate.UpgradeJavaVersion:
+      version: 25