Skip UseMapOf rewrite when the assignment target is a concrete HashMap (#1148)

Author: timtebeek

src/main/java/org/openrewrite/java/migrate/util/UseMapOf.java

@@ -111,6 +111,12 @@ public J visitNewClass(J.NewClass newClass, ExecutionContext ctx) {
                                 TypeUtils.isOfClassType(n.getClazz() != null ? n.getClazz().getType() : null, "java.util.HashMap")) {
                             Statement statement = body.getStatements().get(0);
                             if (statement instanceof J.Block) {
+                                // Skip when the result is assigned to a concrete `HashMap` declared type rather
+                                // than `Map`: the immutable `Map.of(..)` is not assignable to `HashMap`, and
+                                // `HashMap`-only methods may be invoked on the variable later (issue #1148).
+                                if (isAssignedToConcreteHashMap()) {
+                                    return n;
+                                }
                                 List<Statement> putStatements = ((J.Block) statement).getStatements();
                                 List<Expression> args = new ArrayList<>();
                                 boolean useEntries = putStatements.size() > 10;
@@ -194,6 +200,23 @@ private J reattachPairPrefixes(J applied, List<J.MethodInvocation> puts, boolean
                         return nc.withArguments(Collections.singletonList(mapCall.withArguments(withPrefixes)));
                     }
 
+                    /**
+                     * Returns {@code true} when the {@code new HashMap<>() {{ ... }}} currently being visited is
+                     * the initializer of a variable whose declared type is the concrete {@code java.util.HashMap}
+                     * rather than the {@code Map} interface. In that case the immutable {@code Map.of(..)} result
+                     * would not be assignable, and {@code HashMap}-specific methods may be used later, so the
+                     * rewrite is skipped (issue #1148).
+                     */
+                    private boolean isAssignedToConcreteHashMap() {
+                        Object parent = getCursor().getParentTreeCursor().getValue();
+                        if (!(parent instanceof J.VariableDeclarations.NamedVariable)) {
+                            return false;
+                        }
+                        Object grandParent = getCursor().getParentTreeCursor().getParentTreeCursor().getValue();
+                        return grandParent instanceof J.VariableDeclarations &&
+                                TypeUtils.isOfClassType(((J.VariableDeclarations) grandParent).getType(), "java.util.HashMap");
+                    }
+
                     @Override
                     public J visitBlock(J.Block block, ExecutionContext ctx) {
                         Map<UUID, List<J.MethodInvocation>> rewrites = new HashMap<>();

src/test/java/org/openrewrite/java/migrate/util/UseMapOfTest.java

@@ -205,6 +205,48 @@ class Test {
         );
     }
 
+    @Issue("https://github.com/openrewrite/rewrite-migrate-java/issues/1148")
+    @Test
+    void doNotChangeConcreteHashMapField() {
+        //language=java
+        rewriteRun(
+          spec -> spec.allSources(s -> s.markers(javaVersion(25))),
+          java(
+            """
+              import java.util.HashMap;
+
+              class Main {
+                  private static final HashMap<String, String> VALUES = new HashMap<String, String>() {{
+                      put("key", "value");
+                  }};
+              }
+              """
+          )
+        );
+    }
+
+    @Issue("https://github.com/openrewrite/rewrite-migrate-java/issues/1148")
+    @Test
+    void doNotChangeConcreteHashMapLocalVariable() {
+        //language=java
+        rewriteRun(
+          java(
+            """
+              import java.util.HashMap;
+
+              class Main {
+                  void m() {
+                      HashMap<String, Integer> ages = new HashMap<>() {{
+                          put("Bob", 42);
+                          put("alice", 30);
+                      }};
+                  }
+              }
+              """
+          )
+        );
+    }
+
     @Issue("https://github.com/openrewrite/rewrite-migrate-java/issues/1112")
     @Test
     void doNotChangeLinkedHashMap() {